Skip to content

Revert some PRs, fix master#1682

Merged
CyberShadow merged 3 commits intodlang:masterfrom
CyberShadow:pull-20170607-233420
Jun 7, 2017
Merged

Revert some PRs, fix master#1682
CyberShadow merged 3 commits intodlang:masterfrom
CyberShadow:pull-20170607-233420

Conversation

@CyberShadow
Copy link
Member

Let's see if this works

@CyberShadow CyberShadow merged commit 7b8b5d8 into dlang:master Jun 7, 2017
@CyberShadow
Copy link
Member Author

@wilzbach Apologies, I had to revert 3 of your today's PRs to urgently get master green again. I've also fixed the bug which caused DAutoTest to vet bad PRs that had hidden dependencies which it previously did not detect (the problematic PRs were #1671 and #1590). Please rebase and resubmit them.

@wilzbach
Copy link
Contributor

wilzbach commented Jun 8, 2017

@wilzbach Apologies, I had to revert 3 of your today's PRs to urgently get master green again.

Oh I am terribly sorry about this.

I've also fixed the bug which caused DAutoTest to vet bad PRs that had hidden dependencies which it previously did not detect

Good to know :)

Please rebase and resubmit them.

Ok.

@wilzbach
Copy link
Contributor

wilzbach commented Jun 8, 2017

Please rebase and resubmit them.
Ok.

They are #1684, #1685, #1686 - I rebased them individually to master, which has the disadvantage that I probably need to rebase them again once you start merging them, but OTOH isolating the passing from the faulty ones is easier this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants