Skip to content

Rename {DMD,DRUNTIME,PHOBOS,VERSION}_STABLE -> _LATEST#1689

Merged
MartinNowak merged 2 commits intodlang:masterfrom
wilzbach:rename-stable-latest
Sep 20, 2017
Merged

Rename {DMD,DRUNTIME,PHOBOS,VERSION}_STABLE -> _LATEST#1689
MartinNowak merged 2 commits intodlang:masterfrom
wilzbach:rename-stable-latest

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jun 9, 2017

CC @MartinNowak @CyberShadow (follow-up to #1684)

@CyberShadow
Copy link
Member

Why? Are all these renames achieving something?

@wilzbach
Copy link
Contributor Author

wilzbach commented Jun 9, 2017

Cleaning up the Makefile or in Martin's words:

Those should be named {DMD,DRUNTIME,PHOBOS}_LATEST, as they are a specific version, but not intended to be used as stable tool compiler.
In particular confusing since we have a STABLE_DMD_VER in that same makefile.

@CyberShadow
Copy link
Member

OK, deferring to Martin then

@MartinNowak
Copy link
Member

Why? Are all these renames achieving something?

Yes, we want to introduce a new target named release for the installer builds, and use the correct term latest for the current one.
Also the term stable has 2 meanings in the current Makefile.

@wilzbach wilzbach force-pushed the rename-stable-latest branch from 713e3dd to 526dbe2 Compare July 4, 2017 02:19
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach
Copy link
Contributor Author

wilzbach commented Jul 4, 2017

Rebased to the latest, greatest posix.mak. I am assuming that Martin needs to update his diff, so it probably make sense to wait for him here.

@wilzbach wilzbach force-pushed the rename-stable-latest branch from 526dbe2 to 1a1f2f4 Compare September 10, 2017 23:01
@wilzbach
Copy link
Contributor Author

Rebased and this should be good to go now.
IIRC the nightly build server doesn't build the dlang.org anymore, so there's no risk at breaking it again.

@CyberShadow
Copy link
Member

Build is failing.

@MartinNowak
Copy link
Member

Why? Are all these renames achieving something?

Clarifying terminology, the makefile is quite a mess atm.

@MartinNowak MartinNowak merged commit 5ff34a7 into dlang:master Sep 20, 2017
@wilzbach wilzbach deleted the rename-stable-latest branch December 18, 2017 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants