Clean up line about leading stars in style guide.#2166
Merged
dlang-bot merged 1 commit intodlang:masterfrom Feb 3, 2018
Merged
Clean up line about leading stars in style guide.#2166dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @jmdavis! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Contributor
Because you added it ;-) |
wilzbach
approved these changes
Feb 3, 2018
Contributor
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
Fine for me. I have never seen the zeros you were introduced here anyhow, but thought that's some weirdness you observed somewhere.
Member
Author
Figures. I still have no idea why it's there. I was in a bit of a hurry when I created that PR and clearly wasn't careful enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure why it says something about no leading zeroes. It's true that there' shouldn't be any, but AFAIK, no one has been doing it, so it comes off as weird. It's stars that some folks like to do. IIRC, it's a javadoc thing.