Avoid duplicated SWNAMES in to auto-generated CLI output#2193
Merged
dlang-bot merged 1 commit intodlang:masterfrom Feb 9, 2018
Merged
Avoid duplicated SWNAMES in to auto-generated CLI output#2193dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
2 tasks
Member
|
Thanks. Considering this is one step closer to generating pedantically correct HTML, I think it is. |
Contributor
Author
|
And it's also closer to the non-generated version... |
Member
|
(An alternative to not emitting them would be to make them unique) |
CyberShadow
approved these changes
Feb 9, 2018
Contributor
Author
|
(Yes, but then I would have needed to modify the SWNAME macro - not impossible, but resulting in a larger diff. I was torn between both approaches and ultimately went with this one because of the smaller diff and being closer to the "original") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #2068 (comment)
Not so sure whether's really worth bother though.