Skip to content

Improve Variadic function templates article #2224

Merged
wilzbach merged 5 commits intodlang:masterfrom
ntrel:var-ft
Feb 23, 2018
Merged

Improve Variadic function templates article #2224
wilzbach merged 5 commits intodlang:masterfrom
ntrel:var-ft

Conversation

@ntrel
Copy link
Contributor

@ntrel ntrel commented Feb 19, 2018

Following on from #2204:

  • Add short table of contents
  • Update C++ sections for C++11
  • Use sequence instead of tuple.
  • Minor wording changes.
  • Formatting tweaks.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need to make the HEADERTOC generator happy.

)

$(H3 C++ Solutions)
$(H3 $(LNAME2 cpp-solutions, C++ Solutions))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be H2 (and consequently all H2 need to be H3) as the HEADERTOC generation will fail otherwise

)

$(H4 The C++ Extension Solution)
$(H4 C++ Variadic Templates)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H3 + LNAME2 if you want this to appear on the TOC.

@ntrel
Copy link
Contributor Author

ntrel commented Feb 20, 2018

@wilzbach Fixed using H2, tests pass. I've not added anchors for the other headings though.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wilzbach wilzbach merged commit 38e7335 into dlang:master Feb 23, 2018
@ntrel ntrel deleted the var-ft branch February 23, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants