Skip to content

Improve *Foreach over Tuples* spec#2248

Merged
dlang-bot merged 3 commits intodlang:masterfrom
ntrel:foreach-seq
Apr 27, 2018
Merged

Improve *Foreach over Tuples* spec#2248
dlang-bot merged 3 commits intodlang:masterfrom
ntrel:foreach-seq

Conversation

@ntrel
Copy link
Contributor

@ntrel ntrel commented Feb 23, 2018

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If there are
two symbols declared, the first is the $(I index variable)
and the second is the $(I element alias). The index
must be of $(D int) or $(D uint) type, it cannot be `ref`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can also be long: https://run.dlang.io/is/kxSAFP as the index is size_t

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wilzbach I've added long and ulong here, and updated runtime foreach index types, which listed just size_t instead of these. BTW for runtime foreach only, dmd accepts short and byte - I've not documented this though.

@dlang-bot dlang-bot merged commit fe35ad5 into dlang:master Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants