Skip to content

fix issue 2968 by adding pragma(framework)#2719

Closed
benjones wants to merge 1 commit intodlang:masterfrom
benjones:bug2968
Closed

fix issue 2968 by adding pragma(framework)#2719
benjones wants to merge 1 commit intodlang:masterfrom
benjones:bug2968

Conversation

@benjones
Copy link
Contributor

For dmd PR: dlang/dmd#10615

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @benjones! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
2968 enhancement Add a pragma(framework) on osx

@Geod24
Copy link
Member

Geod24 commented Feb 19, 2020

The DMD PR has been closed in favor of linkerDirectives

@adamdruppe
Copy link
Contributor

Just wished I had this again. linkerDirective only works on Windows. framework is a Mac feature.

@kinke
Copy link
Contributor

kinke commented Sep 22, 2023

linkerDirective only works on Windows

That's purely a DMD limitation. pragma({lib,linkerDirective}) work as embedded Mach-O linker directives with LDC, on Windows and Mac.

@adamdruppe
Copy link
Contributor

Alas, extern(Objective-C) doesn't work on ldc, so we're at a useless intersection.

@kinke
Copy link
Contributor

kinke commented Sep 22, 2023

I don't see how that's related - just saying that there's no object-file limitation to make the existing pragmas work with DMD for Mac too, which cover framework use cases and more.

@adamdruppe
Copy link
Contributor

it is related cuz the end goal here requires both, so there's no solution outside patching one or both compilers.

It isn't a difficult patch, but it is hard to realize one's IVY using D when something that was written 14 years ago never got merged cuz "just use this other thing" and said other thing is also broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants