[spec] First enum member is converted from 0 to base type#3694
Merged
dkorpel merged 1 commit intodlang:masterfrom Sep 20, 2023
Merged
[spec] First enum member is converted from 0 to base type#3694dkorpel merged 1 commit intodlang:masterfrom
dkorpel merged 1 commit intodlang:masterfrom
Conversation
Fix Issue 18578 - First enum value assigned 0 instead of EnumBaseType.init.
Contributor
|
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
|
dkorpel
approved these changes
Sep 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue 18578 - First enum value assigned 0 instead of EnumBaseType.init.
Add an example also showing overflow.
@WalterBright suggested fixing the spec rather than breaking existing code:
dlang/dmd#7996 (comment)