Skip to content

Revert "Turn semicolon as empty statement into an error"#15324

Closed
WalterBright wants to merge 1 commit intomasterfrom
revert-15072-semicolon-statement-error
Closed

Revert "Turn semicolon as empty statement into an error"#15324
WalterBright wants to merge 1 commit intomasterfrom
revert-15072-semicolon-statement-error

Conversation

@WalterBright
Copy link
Member

Reverts #15072

Because it isn't really necessary to make empty statements an error, and it causes users unnecessary grief.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15324"

@dkorpel
Copy link
Contributor

dkorpel commented Jun 15, 2023

Because it isn't really necessary to make empty statements an error

Then why turn it back into a deprecation?

@WalterBright
Copy link
Member Author

Because it's easier to review if it is only a revert. The deprecation can be removed as a follow-on.

@maxhaton
Copy link
Member

Target stable

@WalterBright
Copy link
Member Author

@maxhaton good idea! But I never remember how to do it - can you?

@ghost
Copy link

ghost commented Jun 23, 2023

The situation is pretty simple right now. Either it was a deprecation so this PR has to be closed or the previous deprecation is turned into a warning.

@WalterBright WalterBright deleted the revert-15072-semicolon-statement-error branch June 30, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants