Skip to content

Fix macOS ld: multiple errors: symbol count from symbol table and dynamic symbol table differ #16178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ibuclaw wants to merge 5 commits into from
Closed

Fix macOS ld: multiple errors: symbol count from symbol table and dynamic symbol table differ #16178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d00f978
Fix macOS ld: multiple errors: symbol count from symbol table and dyn…
ibuclaw Feb 11, 2024
c170b38
Revert "Fix macOS ld: multiple errors: symbol count from symbol table…
ibuclaw Feb 11, 2024
0c4ed26
osx: Build build tools with -platform_version
ibuclaw Feb 11, 2024
765ae6c
Update ci/run.sh
ibuclaw Feb 15, 2024
9a12c7d
Update compiler/src/dmd/backend/machobj.d
ibuclaw Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ci/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,12 @@ build() {
if [ "$OS_NAME" != "windows" ]; then
source ~/dlang/*/activate # activate host compiler, incl. setting `DMD`
fi
$DMD compiler/src/build.d -ofgenerated/build
BUILD_DFLAGS=
if [ "$OS_NAME" == "osx" ]; then
BUILD_DFLAGS="-L-ld_classic"
CI_DFLAGS="$CI_DFLAGS $BUILD_DFLAGS"
fi
$DMD compiler/src/build.d -ofgenerated/build $BUILD_DFLAGS
generated/build -j$N MODEL=$MODEL HOST_DMD=$DMD DFLAGS="$CI_DFLAGS" BUILD=debug unittest
generated/build -j$N MODEL=$MODEL HOST_DMD=$DMD DFLAGS="$CI_DFLAGS" ENABLE_RELEASE=1 dmd
make -j$N -C druntime MODEL=$MODEL
Expand Down
3 changes: 3 additions & 0 deletions compiler/src/build.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,6 +1002,9 @@ alias toolchainInfo = makeRule!((builder, rule) => builder

app.put("==== Toolchain Information ====\n");

version (OSX)
show("OS", ["sw_vers"]);

version (Windows)
show("SYSTEM", ["systeminfo"]);
else
Expand Down
1 change: 1 addition & 0 deletions compiler/src/dmd/backend/machobj.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1426,6 +1426,7 @@ void MachObj_term(const(char)* objfilename)
sym32.n_sect = sym.n_sect;
fobjbuf.write(&sym32, sym32.sizeof);
}
dysymtab_cmd.nundefsym++;
symtab_cmd.nsyms++;
}
foffset += symtab_cmd.nsyms * (I64 ? nlist_64.sizeof : nlist.sizeof);
Expand Down