Fix Bugzilla 20297 - Link warning: no platform load command found in object.o, assuming: macOS#16223
Merged
thewilsonator merged 1 commit intodlang:stablefrom Feb 22, 2024
Merged
Conversation
ibuclaw
added
Severity:Bug Fix
Compiler:Backend
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#16223" |
thewilsonator
approved these changes
Feb 22, 2024
…object.o, assuming: macOS Co-authored-by: Jacob Carlborg <doob@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encode
.macosx_version_minor.build_versioninto the object file, originally authored by @jacob-carlborg in #10476.This has been simplified to omit parsing the SDK version. Based on what I see GCC is doing (
-platform_version macos $version_min 0.0), this information is not required in order for things to work. Should support for SDKs/frameworks be wanted in future, then that can be done as a feature, not a bug fix.This is good for both i386 and x86_64, as
.macosx_version_minhas been around since the beginning of macOS X.No tests required as it effects all objects compiled by dmd.
(And earlier iteration of this was done in #16178).