Skip to content

Fix Issue 22614 - [Windows] tmpnam() in runPreprocessor generates roo… #22615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewilsonator merged 2 commits into from
Mar 2, 2026
Merged

Fix Issue 22614 - [Windows] tmpnam() in runPreprocessor generates roo… #22615

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15b526b
Fix Issue 22614 - [Windows] tmpnam() in runPreprocessor generates roo…
divyansharma001 Feb 22, 2026
e2e60c3
Fix temporary file creation in runPreprocessor to handle errors on Wi…
divyansharma001 Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions compiler/src/dmd/link.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,9 +958,13 @@ public int runPreprocessor(Loc loc, const(char)[] cpp, const(char)[] filename, c
version (Windows)
{
// generate unique temporary file name for preprocessed output
const(char)* tmpname = tmpnam(null);
assert(tmpname);
const(char)[] ifilename = tmpname[0 .. strlen(tmpname) + 1];
char[MAX_PATH] tempDir = void;
char[MAX_PATH] tempFile = void;
if (GetTempPathA(MAX_PATH, tempDir.ptr) == 0)
Copy link
Member

@rainers rainers Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, but this should use the wide string API and convert the result to UTF8 to avoid bad encoding of the user home directory if it contains non-ascii characters.

Copy link
Author

@divyansharma001 divyansharma001 Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that.

return STATUS_FAILED;
if (GetTempFileNameA(tempDir.ptr, "dmd", 0, tempFile.ptr) == 0)
return STATUS_FAILED;
const(char)[] ifilename = tempFile[0 .. strlen(tempFile.ptr) + 1];
ifilename = xarraydup(ifilename);
const(char)[] output = ifilename;

Expand Down
Loading