Fix #22690: Use correct fstatat mangling on macOS/x64#22689
Merged
thewilsonator merged 1 commit intodlang:stablefrom Mar 3, 2026
Merged
Fix #22690: Use correct fstatat mangling on macOS/x64#22689thewilsonator merged 1 commit intodlang:stablefrom
thewilsonator merged 1 commit intodlang:stablefrom
Conversation
The x64 version of fstatat() needs to be mangled with the "INODE64" suffix in order to match the stat_t layout defined by Druntime. See https://github.com/apple-oss-distributions/xnu/blob/f6217f891ac0bb64f3d375211650a4c1ff8ca1ea/bsd/sys/stat.h#L573
Contributor
|
Thanks for your pull request, @s-ludwig! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#22689" |
s-ludwig
changed the title
kinke
approved these changes
Mar 3, 2026
thewilsonator
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DMD 2.112.0 has introduced declarations for
fstatat, but the x64 version for macOS needs to be mangled with the "$INODE64" suffix (like the other "stat" functions) in order to match the correctstat_tlayout.See https://github.com/apple-oss-distributions/xnu/blob/f6217f891ac0bb64f3d375211650a4c1ff8ca1ea/bsd/sys/stat.h#L573
This fixes a regression in vibe-core that lead to its
listDirectoryfunction returning wrong file attributes with DMD 2.112.0 and LDC 1.42.0.