Fix Issue 19419 - [REG2.080.1] @disabled this() will print wrong error if calling non-default constructor with wrong parameters#8994
Merged
RazvanN7 merged 1 commit intodlang:stablefrom Nov 22, 2018
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#8994" |
daf9f82 to
33eba16
Compare
…r if calling non-default constructor with wrong parameters
33eba16 to
837bbc2
Compare
thewilsonator
approved these changes
Nov 22, 2018
Contributor
Author
|
Looks like it's the same old issue with stable and C++ namespace; unrelated to this PR. |
Contributor
|
Hmm, bummer. |
Contributor
Author
|
We can force push it, just like: #8951 |
Contributor
|
OK (I'm going to sleep soon). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced by [1]. The check for disabled should only be made for NewDeclarations, for all other functions that is being taken care of before.
[1] #8042