[dmd-cxx] Backport add toTypeFunction() to catch bad casts#9054
Merged
thewilsonator merged 1 commit intodlang:dmd-cxxfrom Dec 9, 2018
Merged
[dmd-cxx] Backport add toTypeFunction() to catch bad casts#9054thewilsonator merged 1 commit intodlang:dmd-cxxfrom
thewilsonator merged 1 commit intodlang:dmd-cxxfrom
Conversation
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "dmd-cxx + dmd#9054" |
thewilsonator
approved these changes
Dec 9, 2018
kraj
pushed a commit
to kraj/gcc
that referenced
this pull request
Dec 17, 2018
Backports a fix where a bad cast to TypeFunction resulted in memory corruption. The logic in the function semantic has been fixed, and casts have been replaced with a function call to always check the front-end AST node value. Reviewed-on: dlang/dmd#9054 git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@267207 138bc75d-0d04-0410-961f-82ee72b054a4
asiekierka
pushed a commit
to WonderfulToolchain/gcc
that referenced
this pull request
May 16, 2022
Backports a fix where a bad cast to TypeFunction resulted in memory corruption. The logic in the function semantic has been fixed, and casts have been replaced with a function call to always check the front-end AST node value. Reviewed-on: dlang/dmd#9054 From-SVN: r267207
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport from #6643. When running D2 testsuite with ubsan build, it was throwing errors in FuncDeclaration::semantic.
e.g:
This was because of blind casting from TypeError to TypeFunction, which was fixed in master by this PR.