This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Unify Makefile variables for dlang.org: Rename DOCDIR -> DOC_OUTPUT_DIR, DOCFMT -> STDDOC#1834
Merged
dlang-bot merged 1 commit intodlang:masterfrom Nov 2, 2021
Merged
Conversation
Member
|
Some documentation in the makefile itself is necessary for these additions. Document what the variable is for and what its expected values are and who should be setting/overriding it. |
…IR, DOCFMT -> STDDOC
RazvanN7
force-pushed
the
unify-makefile-variables
branch
from
ceec3fa to
2874115
Compare
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#1834" |
RazvanN7
approved these changes
Nov 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an attempt to reduce the mess in the dlang.org Makefile, it makes sense and helps to use the same variable names for the same things.
DOC_OUTPUT_DIRandSTDDOCare already used at Phobos + DMD.