Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Annotate toThread parameter t with return scope#3471

Merged
dlang-bot merged 1 commit intodlang:stablefrom
nordlow:fix-pure-scope
May 14, 2021
Merged

Annotate toThread parameter t with return scope#3471
dlang-bot merged 1 commit intodlang:stablefrom
nordlow:fix-pure-scope

Conversation

@nordlow
Copy link
Contributor

@nordlow nordlow commented May 14, 2021

@nordlow nordlow requested review from andralex and wilzbach as code owners May 14, 2021 11:10
@dlang-bot
Copy link
Contributor

dlang-bot commented May 14, 2021

Thanks for your pull request and interest in making D better, @nordlow! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + druntime#3471"

@thewilsonator
Copy link
Contributor

need to target stable.

@nordlow nordlow changed the base branch from master to stable May 14, 2021 11:11
@nordlow
Copy link
Contributor Author

nordlow commented May 14, 2021

need to target stable.

Thanks, done.

@Geod24
Copy link
Member

Geod24 commented May 14, 2021

Need a rebase too.

@nordlow
Copy link
Contributor Author

nordlow commented May 14, 2021

Need a rebase too.

Done

@nordlow
Copy link
Contributor Author

nordlow commented May 14, 2021

Need a rebase too.

Done

Hmm, the diff doesn't look right...

@nordlow
Copy link
Contributor Author

nordlow commented May 14, 2021

Need a rebase too.

Done

Hmm, the diff doesn't look right...

Rebase again. Should be ok now, @Geod24

@dlang-bot dlang-bot merged commit 22fbfc7 into dlang:stable May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants