dub run <package> should search the registry on failure by wilzbach · Pull Request #1082 · dlang/dub

wilzbach · 2017-02-23T12:15:07Z

Adds a simple fallback to dub run, s.t. the following pattern simply works:

dub run dlang-tour
dub run dfmt
dub run dscanner
dub run avgtime
...

I am not sure how we can best test this without querying the registry. Also I don't know any package that is compatible with all the compilers that DUB supports.
What would be the best strategy here?

s-ludwig · 2017-02-23T14:40:52Z

What about making this slightly interactive and requiring the user to confirm the download. This would also be a chance to print the package description and maybe the github address, to make it less likely to make this en entry point for malicious code.

There is http://code.dlang.org/packages/gitcompatibledubpackage which is used in some of the tests already. We'd just have to add an executable configuration (in this case just a source/app.d).

wilzbach · 2017-02-23T16:16:04Z

What about making this slightly interactive and requiring the user to confirm the download. This would also be a chance to print the package description and maybe the github address, to make it less likely to make this en entry point for malicious code.

Good idea - I gave it a shot. It's not perfect because without more refactoring the info payload will get downloaded twice from the registry.

There is http://code.dlang.org/packages/gitcompatibledubpackage which is used in some of the tests already. We'd just have to add an executable configuration

https://github.com/MartinNowak/gitcompatibledubpackage/pull/1/files

I also added a test for this -> Travis will fail for a bit.

MartinNowak · 2017-04-05T22:13:15Z

https://github.com/MartinNowak/gitcompatibledubpackage/pull/1/files

I also added a test for this -> Travis will fail for a bit.

Merged

s-ludwig · 2017-04-06T12:31:21Z

Appears that issue877-auto-download-package-if-not-found-on-error.sh is still missing an echo "y" |, or maybe a command line option that does the same. Ideally, it would also detect that stdin is empty (does that work using an EOF check?) and assume "n" in that case (would be backwards compatible and avoids unsolicited downloads).

MartinNowak · 2017-04-08T11:26:53Z

test/issue877-auto-download-package-if-not-found-on-error.sh

+set -e -o pipefail
+
+$DUB remove --version='*' cpuid > /dev/null 2>&1 || true
+$DUB run dfmt


How is that different from the test below?

MartinNowak · 2017-04-08T11:27:11Z

source/dub/commandline.d

+				if (json == Json.emptyObject)
+					return 2;
+
+				writefln("%s wasn't found online, but there's version available online:", package_name);


dfmt wasn't found online, but there's version available online???

MartinNowak · 2017-04-08T11:29:49Z

source/dub/commandline.d

+				writefln("%s wasn't found online, but there's version available online:", package_name);
+				if ("authors" in json)
+					writefln("Authors: %-(%s, %)", json["authors"][].map!(v => v.get!string));
+				if ("license" in json)


How about

if (auto p = "license" in json) writefln("Description: %s", p.get!string);

MartinNowak · 2017-04-08T11:30:54Z

source/dub/commandline.d

+				if ("version" in json)
+					writefln("Version: %s", json["version"].get!string);
+				if ("description" in json)
+					writefln("License: %s", json["license"].get!string);


Description and License are mixed up.

MartinNowak · 2017-04-08T11:31:42Z

source/dub/commandline.d

+						  default:
+						}
+					} else {
+						nb = true;


Should be the default value, no?

MartinNowak · 2017-04-08T11:33:15Z

source/dub/commandline.d

+							nb = true;
+						  case "no", "n":
+							nb = false;
+						  default:


I'd rather loop in here, than on the outside. Also allows you to drop Nullable.

MartinNowak · 2017-04-08T11:36:28Z

source/dub/commandline.d

+					logInfo("Retry with ~master...");
+					dep = Dependency("~master");
+					json = dub.info(package_name, dep, fetchOpts, supplier);
+				}


Could this maybe reuse dub.searchPackages?

MartinNowak · 2017-04-08T11:38:16Z

source/dub/commandline.d

+			auto package_name = free_args[0];
+			auto pack = dub.packageManager.getFirstPackage(package_name);
+
+			if (!pack)


Please check some --non-interactive argument as well to prevent hanging scripts.

Dub packages must first be fetched before you can run them, at least until dlang/dub#1082 is accepted.

dlang-bot · 2017-09-14T22:54:02Z

Thanks for your pull request, @wilzbach!

wilzbach · 2017-09-14T23:01:33Z

Okay I finally found time to rebase and rework this. Thanks to @MartinNowak's feedback and the time passed since I submitted this, I managed to cut the size of this PR in half :)

This only needs a new release of gitcompatibledubpackage as dlang-community/gitcompatibledubpackage#1 isn't part of the dummy package's 1.0.2 release (@MartinNowak: how about moving this package to dlang-community?)

s-ludwig · 2017-09-14T23:04:43Z

source/dub/commandline.d

+
+				bool answer = input("Do you want to fetch %s?".format(package_name));
+				auto dep = Dependency(p.version_);
+				dub.fetch(package_name, dep, dub.defaultPlacementLocation, fetchOpts);


Nitpick: since the package doesn't exist locally, FetchOptions.forceBranchUpgrade shouldn't have an effect and FetchOptions.none would be sufficient here.

wilzbach · 2018-03-28T05:16:50Z

I accidentally closed this PR because I wanted to trigger a notification to Semaphore while I pushed and GitHub doesn't seem to like this (even restoring the old commit sha still doesn't allow me to reopen).

Anyway, I opened a new PR -> #1428
Sorry for the noise.

wilzbach mentioned this pull request Feb 23, 2017

dub build -b dscanner #814

Closed

wilzbach mentioned this pull request Feb 23, 2017

Add Hello DUB executable config dlang-community/gitcompatibledubpackage#1

Merged

MartinNowak requested changes Apr 8, 2017

View reviewed changes

wilzbach mentioned this pull request Jun 25, 2017

Auto-compile linenoise on build dlang-community/drepl#63

Merged

PetarKirov added a commit to PetarKirov/Digger that referenced this pull request Jun 29, 2017

Correct "Get Digger" section about dub

0787481

Dub packages must first be fetched before you can run them, at least until dlang/dub#1082 is accepted.

PetarKirov mentioned this pull request Jun 29, 2017

Correct "Get Digger" section about dub CyberShadow/Digger#60

Merged

CyberShadow pushed a commit to CyberShadow/Digger that referenced this pull request Jun 29, 2017

Correct "Get Digger" section about dub

93c8344

Dub packages must first be fetched before you can run them, at least until dlang/dub#1082 is accepted.

wilzbach force-pushed the fix-877 branch from fa46b8c to 350d2d0 Compare September 14, 2017 22:54

wilzbach force-pushed the fix-877 branch 3 times, most recently from 473f67a to f6cf601 Compare September 14, 2017 22:59

s-ludwig reviewed Sep 14, 2017

View reviewed changes

wilzbach force-pushed the fix-877 branch from f6cf601 to 9cc9a6c Compare December 4, 2017 20:21

wilzbach force-pushed the fix-877 branch from 9cc9a6c to 706a105 Compare January 15, 2018 04:59

wilzbach mentioned this pull request Jan 28, 2018

Binary releases for tools dlang-community/discussions#9

Open

dub run <package> should search the registry on failure

8a2ec67

wilzbach closed this Mar 28, 2018

wilzbach force-pushed the fix-877 branch from 706a105 to 8a2ec67 Compare March 28, 2018 05:09

wilzbach mentioned this pull request Mar 28, 2018

dub run <package> should search the registry on failure #1428

Merged

Uh oh!

Conversation

wilzbach commented Feb 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s-ludwig commented Feb 23, 2017

Uh oh!

wilzbach commented Feb 23, 2017

Uh oh!

MartinNowak commented Apr 5, 2017

Uh oh!

s-ludwig commented Apr 6, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dlang-bot commented Sep 14, 2017

Uh oh!

wilzbach commented Sep 14, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilzbach commented Mar 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wilzbach commented Feb 23, 2017 •

edited

Loading