Skip to content

Always set CodeCov notifications to green/passing#1347

Merged
wilzbach merged 1 commit intodlang:masterfrom
wilzbach:codecov
Jan 25, 2018
Merged

Always set CodeCov notifications to green/passing#1347
wilzbach merged 1 commit intodlang:masterfrom
wilzbach:codecov

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jan 24, 2018

As the dlang-bot now won't merge a PR when there's one failure [1], it makes sense
to force CodeCov to be informational. The interesting bit - coverage of the diff -
is still displayed in the CI tab and more importantly the browser extension still
works too and will continue to highlight the uncovered parts in red.

See also: https://github.com/dlang/dmd/blob/master/.codecov.yml

[1] dlang/dlang-bot#69

@dlang-bot
Copy link
Collaborator

Thanks for your pull request, @wilzbach!

@wilzbach wilzbach changed the title Allows set CodeCov notifications to green/passing Always set CodeCov notifications to green/passing Jan 24, 2018
.codecov.yml Outdated
threshold: 0.1
patch:
default:
informational: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we figure that only patch coverage is relevant?
Can we just use status: { patch: { default: { threshold: 5 } } } instead? That should allow patch coverage to be a bit (5 per-cent points) lower than project coverage, but fails (and requires manual review) if it's even lower.
All the other coverage statuses seem superfluous.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but there seems to be a bug at CodeCov which leads to it not showing up at all. I haven't had time to report this to the CodeCov team, but that's what's happening at dmd atm.

@MartinNowak
Copy link
Member

Crazy amount of configuration.

@wilzbach
Copy link
Contributor Author

Didn't we figure that only patch coverage is relevant?

I re-thought this and the error we experience at DMD is actually related to us using multiple builds, so we can safely use only CodeCov patch here.

@wilzbach
Copy link
Contributor Author

The Jenkins failure is unrelated - see dlang/ci#135

@wilzbach wilzbach merged commit cf69cc4 into dlang:master Jan 25, 2018
@wilzbach wilzbach deleted the codecov branch January 25, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants