Skip to content

Enable exact search for maven registry provider#1742

Merged
wilzbach merged 1 commit intodlang:masterfrom
andre2007:maven_search_packages
Jul 31, 2019
Merged

Enable exact search for maven registry provider#1742
wilzbach merged 1 commit intodlang:masterfrom
andre2007:maven_search_packages

Conversation

@andre2007
Copy link
Contributor

@andre2007 andre2007 commented Jul 23, 2019

This will enable downloading dub packages on dub run as introduced by Seb (#1428) also for maven repository provider.

Only exact search is possible, which is sufficient for dub run.
For a "real" search different html dialects (Nexus, Artifactory, ...) has to be parsed.
For example the html code of this site has to be parsed to get the 3 artifacts
https://repo1.maven.org/maven2/com/devspan/vendor/jquery/

@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @andre2007! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

@wilzbach wilzbach merged commit 78f74ae into dlang:master Jul 31, 2019
@andre2007 andre2007 deleted the maven_search_packages branch October 16, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants