fix visuald generator to use selected compiler instead of hardcoded dmd#3094
Open
kmr-ankitt wants to merge 2 commits intodlang:masterfrom
Open
fix visuald generator to use selected compiler instead of hardcoded dmd#3094kmr-ankitt wants to merge 2 commits intodlang:masterfrom
kmr-ankitt wants to merge 2 commits intodlang:masterfrom
Conversation
|
Thanks for your Pull Request and making D better! This comment will automatically be updated to summarize some statistics in a few minutes. |
WebFreak001
requested changes
Mar 2, 2026
| ret.formattedWrite(" <fileImppath>%s</fileImppath>\n", stringImports); | ||
|
|
||
| ret.formattedWrite(" <program>%s</program>\n", "$(DMDInstallDir)windows\\bin\\dmd.exe"); // FIXME: use the actually selected compiler! | ||
| ret.formattedWrite(" <program>%s</program>\n", settings.compiler.name); |
Member
There was a problem hiding this comment.
$(DMDInstallDir) is a placeholder for VisualD, which makes the program portable across PCs - we probably want to keep using it or use some other variables so that it keeps working even if sharing project folders across different PCs
Author
There was a problem hiding this comment.
ok, i get it.
i see these under VisualD
so, using these variables according to the case fixes this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VisualD generator currently hardcodes the DMD executable path.
This change replaces the hardcoded DMD path with the selected compiler
name, ensuring correct behavior across supported compilers.