Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions changelog/add-dest.dd

This file was deleted.

14 changes: 0 additions & 14 deletions changelog/add-frameworks.dd

This file was deleted.

3 changes: 0 additions & 3 deletions changelog/fix-cimport-paths.dd

This file was deleted.

16 changes: 0 additions & 16 deletions changelog/selections_from_parent_dir.dd

This file was deleted.

2 changes: 1 addition & 1 deletion source/dub/compilers/ldc.d
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class LDCCompiler : Compiler {
tuple(BuildOption.color, ["-enable-color"]),

tuple(BuildOption._docs, ["-Dd=docs"]),
tuple(BuildOption._ddox, ["-Xf=docs.json", "-Dd=__dummy_docs"]),
tuple(BuildOption._ddox, ["-Xf=docs.json", "-Dd=__dummy_docs", "-oq"]),
];

@property string name() const { return "ldc"; }
Expand Down
2 changes: 1 addition & 1 deletion source/dub/dub.d
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ class Dub {
enforce(recipe.buildSettings.cSourcePaths.length == 0, "Single-file packages are not allowed to specify C source paths.");
enforce(recipe.buildSettings.importPaths.length == 0, "Single-file packages are not allowed to specify import paths.");
enforce(recipe.buildSettings.cImportPaths.length == 0, "Single-file packages are not allowed to specify C import paths.");
recipe.buildSettings.sourceFiles[""] = [path.toNativeString()];
recipe.buildSettings.sourceFiles[""] = [];
recipe.buildSettings.sourcePaths[""] = [];
recipe.buildSettings.cSourcePaths[""] = [];
recipe.buildSettings.importPaths[""] = [];
Expand Down
10 changes: 8 additions & 2 deletions source/dub/project.d
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,13 @@ class Project {
} else {
auto subconf = pack.package_.getSubConfiguration(c, packages[dp].package_, platform);
if (!subconf.empty) setConfigs(only(subconf));
else setConfigs(packages[dp].package_.getPlatformConfigurations(platform));
else {
setConfigs(packages[dp].package_.getPlatformConfigurations(platform));
if (depconfigs[dp].length == 0) {
// Try with the executables too
setConfigs(packages[dp].package_.getPlatformConfigurations(platform, true));
}
}
}

// if no valid configuration was found for a dependency, don't include the
Expand Down Expand Up @@ -786,7 +792,7 @@ class Project {
if (auto pc = pack.name in m_overriddenConfigs)
determineDependencyConfigs(pack_idx, *pc);
else
foreach (c; pack.package_.getPlatformConfigurations(platform, pack.package_ is m_rootPackage && allow_non_library))
foreach (c; pack.package_.getPlatformConfigurations(platform, allow_non_library))
determineDependencyConfigs(pack_idx, c);
}

Expand Down
2 changes: 1 addition & 1 deletion source/dub/version_.d
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
module dub.version_;
enum dubVersion = "v1.39.0-rc.1";
enum dubVersion = "v1.41.0";
Empty file.
Empty file.
10 changes: 10 additions & 0 deletions test/issue3029_subpack_exe_default_conf/dub.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"name": "issue3029_subpack_exe_default_conf",
"targetType": "none",
"subPackages": [
"sub"
],
"dependencies": {
":sub": "*"
}
}
18 changes: 18 additions & 0 deletions test/issue3029_subpack_exe_default_conf/sub/dub.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"name": "sub",
"targetType": "executable",
"configurations": [
{
"name": "default",
"versions": [
"special"
]
}
],
"postBuildCommands-windows": [
"$DUB_TARGET_NAME"
],
"postBuildCommands-posix": [
"./$DUB_TARGET_NAME"
]
}
15 changes: 15 additions & 0 deletions test/issue3029_subpack_exe_default_conf/sub/source/app.d
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
module app;

int main()
{
version (special)
{
// Expected.
return 0;
}
else
{
// Failure.
return 1;
}
}
Empty file.
Empty file.
13 changes: 13 additions & 0 deletions test/issue595-subpack-exe-subconfig/dub.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"name": "issue595-subpack-exe-subconfig",
"targetType": "none",
"subPackages": [
"sub"
],
"dependencies": {
":sub": "*"
},
"subConfigurations": {
"issue595-subpack-exe-subconfig:sub": "special"
}
}
15 changes: 15 additions & 0 deletions test/issue595-subpack-exe-subconfig/sub/dub.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"name": "sub",
"targetType": "executable",
"configurations": [
{
"name": "default"
},
{
"name": "special",
"versions": [
"special"
]
}
]
}
13 changes: 13 additions & 0 deletions test/issue595-subpack-exe-subconfig/sub/source/app.d
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import std.stdio;

void main()
{
version (special)
{
writeln("Special version");
}
else
{
writeln("Standard version");
}
}
Loading