Skip to content

Merge master#734

Closed
ibuclaw wants to merge 6 commits intodlang:stablefrom
ibuclaw:merge_master
Closed

Merge master#734
ibuclaw wants to merge 6 commits intodlang:stablefrom
ibuclaw:merge_master

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Mar 2, 2026

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@ibuclaw ibuclaw requested a review from dkorpel March 2, 2026 17:27
@ibuclaw
Copy link
Member Author

ibuclaw commented Mar 2, 2026

installer\test\release\dub_example.d: Error: module dub_example from file installer\test\release\dub_example.d is specified twice on the command line
Error D:\a\installer\installer\installer\test\release\generated\dmd2\windows\bin\dmd.exe failed with exit code 1.
Error: Process completed with exit code 2.

@kinke - don't know what's going on, it did succeed here: https://github.com/dlang/installer/actions/runs/22586754509/job/65434333450

which contains no clear differences to this merge https://github.com/dlang/installer/pull/733/changes

@ibuclaw
Copy link
Member Author

ibuclaw commented Mar 2, 2026

installer\test\release\dub_example.d: Error: module dub_example from file installer\test\release\dub_example.d is specified twice on the command line
Error D:\a\installer\installer\installer\test\release\generated\dmd2\windows\bin\dmd.exe failed with exit code 1.
Error: Process completed with exit code 2.

@kinke - don't know what's going on, it did succeed here: https://github.com/dlang/installer/actions/runs/22586754509/job/65434333450

which contains no clear differences to this merge https://github.com/dlang/installer/pull/733/changes

Oh, it's passing on dmd-stable (on:pull_request) but not dmd-master (on:push).

Strange that that latter didn't trigger in the previous PR.

@ibuclaw ibuclaw closed this Mar 2, 2026
@ibuclaw ibuclaw deleted the merge_master branch March 2, 2026 18:32
@ibuclaw
Copy link
Member Author

ibuclaw commented Mar 2, 2026

@dkorpel lets pause for a moment whilst we fix the remaining issues?

Ubuntu:

2026-03-02T17:49:48.1233591Z std.file.FileException@/opt/hostedtoolcache/dc/ldc2-1.42.0/x64/ldc2-1.42.0-linux-x86_64/bin/../import/std/file.d(2077): 'default:clones/installer/linux/*.deb': No such file or directory
2026-03-02T17:49:48.1601153Z ----------------

Caller uses a quoted string "'default:...'"
https://github.com/dlang/installer/blob/master/create_dmd_release/build_all.d#L327

But box.scp() doesn't handle this.

void scp(string src, string tgt)
{
version(NoVagrant)
{
if (src.startsWith("default:"))
src = _tmpdir ~ "/" ~ src[8..$];

@kinke
Copy link
Contributor

kinke commented Mar 3, 2026

installer\test\release\dub_example.d: Error: module dub_example from file installer\test\release\dub_example.d is specified twice on the command line
Error D:\a\installer\installer\installer\test\release\generated\dmd2\windows\bin\dmd.exe failed with exit code 1.
Error: Process completed with exit code 2.

Argh yeah that's dlang/dub#3030.

@kinke
Copy link
Contributor

kinke commented Mar 4, 2026

Which I had worked around in a8c50fb, and then reverted in 08fc8d8. So either this has regressed in dub a 2nd time now, or the used dub version is old.

@kinke
Copy link
Contributor

kinke commented Mar 4, 2026

Looks as if dub master has regressed again, while dub stable is fine.

Edit: Oh wow, that fix in dub stable still hasn't landed in dub master!
Edit2: dlang/dub#3096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants