Skip to content

build_release_template.yml: Chomp the prefixing 'v' from the release branch#739

Merged
ibuclaw merged 1 commit intodlang:stablefrom
ibuclaw:win_chompprefix_ver
Mar 3, 2026
Merged

build_release_template.yml: Chomp the prefixing 'v' from the release branch#739
ibuclaw merged 1 commit intodlang:stablefrom
ibuclaw:win_chompprefix_ver

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Mar 3, 2026

Windows release build currently fails because the 7z file doesn't exist.

7-Zip 26.00 (x64) : Copyright (c) 1999-2026 Igor Pavlov : 2026-02-12

ERROR: The system cannot find the file specified.
create_dmd_release\build\dmd.v2.112.1-rc.1.windows.7z

This is because build_all calls chompPrefix("v") on the version string before using it in all archive names.

Copying file 'C:\Users\RUNNER~1\AppData\Local\Temp\tmp.8319A2/dmd.2.112.1-rc.1.windows.zip' to 'build/dmd.2.112.1-rc.1.windows.zip'.
Building LZMA archive 'build/dmd.2.112.1-rc.1.windows.7z'.

I don't understand batch script, so this may be completely off the mark.

@rainers ? @kinke ?

@ibuclaw ibuclaw requested review from dkorpel, kinke and rainers March 3, 2026 12:46
@ibuclaw ibuclaw added the Windows label Mar 3, 2026
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@ibuclaw
Copy link
Member Author

ibuclaw commented Mar 3, 2026

Guess worse it can do is not work, if so, revert :-)

@ibuclaw ibuclaw merged commit 40bc9ab into dlang:stable Mar 3, 2026
13 of 14 checks passed
@ibuclaw ibuclaw deleted the win_chompprefix_ver branch March 3, 2026 13:31
@kinke
Copy link
Contributor

kinke commented Mar 3, 2026

Should be fine. :)

@ibuclaw
Copy link
Member Author

ibuclaw commented Mar 3, 2026

Should be fine. :)

Apparently it was! 🥳

https://github.com/dlang/dmd/actions/runs/22625433986

Only blocked on dlang/dmd#22686 I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants