build_release_template.yml: Chomp the prefixing 'v' from the release branch#739
Merged
ibuclaw merged 1 commit intodlang:stablefrom Mar 3, 2026
Merged
Conversation
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
dkorpel
approved these changes
Mar 3, 2026
Member
Author
|
Guess worse it can do is not work, if so, revert :-) |
Contributor
|
Should be fine. :) |
Member
Author
Apparently it was! 🥳 https://github.com/dlang/dmd/actions/runs/22625433986 Only blocked on dlang/dmd#22686 I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows release build currently fails because the 7z file doesn't exist.
This is because build_all calls
chompPrefix("v")on the version string before using it in all archive names.I don't understand batch script, so this may be completely off the mark.
@rainers ? @kinke ?