Skip to content

Add length property to cartesianProduct for finite forward ranges#10961

Merged
pbackus merged 5 commits intodlang:masterfrom
manavgupta26:fix-9871-cartesianProduct-length-clean
Feb 22, 2026
Merged

Add length property to cartesianProduct for finite forward ranges#10961
pbackus merged 5 commits intodlang:masterfrom
manavgupta26:fix-9871-cartesianProduct-length-clean

Conversation

@manavgupta26
Copy link
Contributor

Fixes issue 9871

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @manavgupta26! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10961"

Copy link
Contributor

@pbackus pbackus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a unit test.

// For infinite ranges or non-forward ranges, we fall back to the old
// implementation which expands an exponential number of templates.
import std.typecons : tuple;
import std.algorithm : allSatisfy;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import std.algorithm : allSatisfy;
import std.meta : allSatisfy;

This should fix the style check failure.

@pbackus
Copy link
Contributor

pbackus commented Feb 21, 2026

std/algorithm/setops.d(425): Error: mutable method `std.algorithm.setops.__unittest_L575_C7.MapResult!(__lambda_L578_C28, int[]).MapResult.ImplementLength!(_input).length` is not callable using a `const` object
                   result *= r.length;
                             ^

The problem is that cartesianProduct's length method is const, but MapResult's length method is not.

@pbackus pbackus merged commit cf71625 into dlang:master Feb 22, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants