Skip to content

Fix issue 10962 - improved handling of gammaIncompleteCompleInverse edge cases#10963

Merged
thewilsonator merged 1 commit intodlang:masterfrom
tedgin:10962
Feb 22, 2026
Merged

Fix issue 10962 - improved handling of gammaIncompleteCompleInverse edge cases#10963
thewilsonator merged 1 commit intodlang:masterfrom
tedgin:10962

Conversation

@tedgin
Copy link
Contributor

@tedgin tedgin commented Feb 22, 2026

This resolves issue #10962.

  • Made NaN handling conform to that of builtin binary operators, i.e., when both input values are NaN, the one with the larger payload is returned.
  • Extended domain coverage to handle a = +0
  • Short circuit cases where Q isn't invertible and return NaN
  • Explicitly handle p = 1 edge case.

* Made NaN handling conform to that of builtin binary operators, i.e.,
  when both input values are NaN, the one with the larger payload is
  returned.
* Extended domain coverage to handle a = +0
* Short circuit cases where Q isn't invertible and return NaN
* Explicitly handle p = 1 edge case.
@tedgin tedgin requested a review from ibuclaw as a code owner February 22, 2026 20:13
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @tedgin! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10963"

@thewilsonator thewilsonator merged commit dc57a61 into dlang:master Feb 22, 2026
10 checks passed
@tedgin tedgin deleted the 10962 branch February 25, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gammaIncompleteComplInverse not handling p=1 edge case correctly

4 participants