Fix Issue 17283 - std.experimental.typecons uses private module members#5319
Merged
dlang-bot merged 1 commit intodlang:masterfrom Apr 3, 2017
Merged
Fix Issue 17283 - std.experimental.typecons uses private module members#5319dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
JackStouffer
approved these changes
Apr 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was discovered while trying to fix a compiler bug (see [1]). It turns out that std.experimental.typecons uses some templates from std.typecons which are private. Since the templates are used in another module, I modified the private attribute to package. At the moment, this is blocking the merging of [1]
[1] dlang/dmd#6660