Skip to content

[trivial] Tweak std.meta docs#6146

Merged
dlang-bot merged 3 commits intodlang:masterfrom
ntrel:meta-docs
Feb 23, 2018
Merged

[trivial] Tweak std.meta docs#6146
dlang-bot merged 3 commits intodlang:masterfrom
ntrel:meta-docs

Conversation

@ntrel
Copy link
Contributor

@ntrel ntrel commented Feb 9, 2018

  • Replace uses of list with sequence.
  • S[n] is not the nth element (due to zero based indexing).
  • Add links, formatting.

Replace uses of 'list' with sequence.
S[n] is not the nth element (zero based).
Add links, formatting.
@dlang-bot dlang-bot added the Review:Trivial typos, formatting, comments label Feb 9, 2018
@dlang-bot
Copy link
Contributor

dlang-bot commented Feb 9, 2018

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

std/meta.d Outdated
* such as TL[$(I n)] which gets the $(I n)th type from the
* alias sequence. TL[$(I lwr) .. $(I upr)] returns a new type
* list that is a slice of the old one.
* Some operations on alias sequences are built into the language -
Copy link
Contributor

@JackStouffer JackStouffer Feb 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comma was correct. - is not a valid way to make a sub-clause of a sentence.


/**
* Returns the `AliasSeq` TList with the types sorted so that the most
* Returns an `AliasSeq` with the elements of TList sorted so that the most
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're modifying this line anyway, might as well change

`AliasSeq`

to

$(LREF AliasSeq)

Same throughout.

Copy link
Member

@MetaLang MetaLang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the change to the comma pointed out by @JackStouffer, LGTM.

@ntrel
Copy link
Contributor Author

ntrel commented Feb 20, 2018

I restored the comma, I've not made the LREF change. I changed a link title to match dlang/dlang.org#2204.

@JackStouffer
Copy link
Contributor

I've not made the LREF change

Any particular reason?

@ntrel
Copy link
Contributor Author

ntrel commented Feb 23, 2018

@JackStouffer Just that I didn't want to get into another change unless it added significant value. Merge please? ;-)

@dlang-bot dlang-bot merged commit 6c3b889 into dlang:master Feb 23, 2018
@ntrel ntrel deleted the meta-docs branch February 26, 2018 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants