Accomodate Enum init deprecation#6368
Merged
dlang-bot merged 1 commit intodlang:masterfrom Mar 29, 2018
Merged
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6368" |
JackStouffer
approved these changes
Mar 29, 2018
Contributor
|
@WalterBright PRs need at least one approval to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR dlang/dmd#7996 is modifying the compiler to comply with the language specification:
The current behavior is to assign the value
0to the first enum member when no assign expression is given. The referenced PR introduces a deprecation message when an enum's base type's.initmember is not 0. This applies to the typesdouble,charandreal. This allows applications to maintain the current behavior for a time until the deprecation is over and the behavior will change to match the specification. Note that this means you cannot currently create an enum with base typedouble,charorrealwithout a deprecation message unless you give it's first member an explicit assignment. Since phobos treats deprecations as errors, this PR provides explicit assignments in these cases during this deprecation period.