StringRef ref counting and proper deallocation#19
Merged
dmgcodevil merged 2 commits intomainfrom Oct 9, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a thread-safe intrusive reference counting system for
StringRefto solve critical concurrent string access issues in TundraDB. This replaces the previous unsafe string management approach that risked use-after-free bugs during concurrent node updates.Problem Statement
Before this PR:
Specific issue:
Solution
Implemented intrusive reference counting where the ref count is stored IN the arena memory, directly before the string data. This provides:
Memory Layout:
Architecture Changes
New Clean Header Structure: