This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Implemented auto-setup of database specified by withDatabaseName and … #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/main/java/org/testcontainers/containers/MSSQLServerContainer.java
Conflicts: src/main/java/org/testcontainers/containers/MSSQLServerContainer.java
Conflicts: src/main/java/org/testcontainers/containers/MSSQLServerContainer.java
…properly so I've changed it.
Contributor
|
Is there a specific reason to not require a JDBC driver? The default behaviour of JdbcDatabaseContainer is to use the JDBC driver and make a test query to verify that the database is ready to accept queries. The behaviour is now in place after merging #6. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...withCollation
I've implemented the requested changes of pull-request "Custom db auto setup #4" but with using the native command line tool inside the MS SQL Server container to set up everything. So the MS SQL Server driver is not needed in the module.