grVenom matches #2146
Merged
grVenom matches #2146
+928
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- grVenom_80204CEC (100%) - grVenom_80205E84 (100%) - grVenom_80206CB0 (100%) - grVenom_80206D10 (100%) - grVenom_80206D7C (100%) Fix prototypes in grcorneria.h and grvenom.h for proper linking.
Contributor
Report for GALE01 (4781872 - 7ddf398)📈 Matched code: 51.05% (+0.06%, +2416 bytes) ✅ 12 new matches
📈 10 improvements in unmatched functions
|
- grVenom_80203EAC: 100% - ground object initialization - grVenom_802052E0: 99.71% - spawn position calculation - grVenom_802056B0: 100% - ground object animation setup Uses extern data symbols (grVe_803E5348, grVe_803E5380, etc.)
Contributor
Author
|
WIP. Pushing more matches in a few |
ribbanya
reviewed
Jan 29, 2026
Co-authored-by: Robin Avery <robin@ribbanya.dev>
Matched: - grVenom_80204B88 (100%) - stage lighting colors Partial matches (compiling): - grVenom_802053B0 (95.38%) - enemy state machine - grVenom_80203B18 (96.16%) - stage initialization Partial matches (commented out with #if 0): - grVenom_80204284 (68.27%) - grVenom_80205AD4 (72.36%) - grVenom_80206874 (64.02%) Added externs for grVe_804D* data symbols and GXColor globals. Fixed grVenom_80204B88 header prototype.
- grVenom_80204284: 97.29% match (was 68%, needs minor regalloc fix) - grVenom_80205AD4: 92.66% match (was 72%, needs code ordering fix) - grVenom_80206874: Kept as stub (32.92% < 50% threshold) - Fix grCorneria_801E25C4 prototype from UNK_PARAMS to actual signature Following new 50% contribution policy - partial matches to be reviewed.
- grVenom_8020362C: 81.23% match (Venom stage ship spawning logic) - Add baselib/random.h include for HSD_Randi/HSD_Randf - Extend grVe_TimingData struct with x8, xC, x10 fields - Add local grVe_ExtData, grVe_Lighting, grVe_GroundData structs TODO: Move local structs to proper headers, fix remaining 19% mismatch
Contributor
Author
|
Running permuter on 99% matches, then doing my own review, then flagging for review, please be patient 😆 |
Permuter-derived fixes: - grVenom_802040F0: Add new_var temp for gp, use in xD0 access - grVenom_80204DD4: Pre-compute flag check and jobj copy - grVenom_80206BF0: Add PAD_STACK(32) for stack frame match - grVenom_802052E0: Add temp variables (99.92%, close but not 100%) Progress: 51.05% matched
malvarezcastillo
force-pushed
the
decomp/grvenom
branch
from
985a754 to
e3c1a3d
Compare
PsiLupan
previously requested changes
Jan 30, 2026
- Revert grVenom_8020362C to stub (reviewer found code quality poor) - Change grVenom_80206D7C first param from void* to Vec3* - Remove redundant mpJointFromLine forward declaration (mplib.h included) - Remove unnecessary "// Decompilation of" comments - Add FAKE MATCH comment explaining jobj.h line number mismatch - Use JOBJ flag constants instead of magic numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.