Skip to content

Bugfix to get the terrain following coordinate actually in place#10

Merged
domingom merged 5 commits intodevelopfrom
bugfix_terrain_following
Mar 26, 2025
Merged

Bugfix to get the terrain following coordinate actually in place#10
domingom merged 5 commits intodevelopfrom
bugfix_terrain_following

Conversation

@jsauer-NCAR
Copy link
Collaborator

Expected Differences

  • [x ] Do these changes introduce new tools, command line arguments, or configuration file options? [Yes or No]

    If yes, please describe:

    No

Pull Request Testing

  • [x ] Describe testing already performed for these changes:

    Verified flow sonsequences for a Ug=8.0 m/s flow past a 15m WOA hill in a periodic domain
  • [x ] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    No further testing at this time. Future CI test members should explicitly verify molecular diffusion and sgs turbulence, sgs TKE, etc.
  • [x ] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    No, a future pull request should patch the v2.0 release with adjustments to the terrain inclusive Dispersion tutorial examples.
  • [x ] Do these changes include sufficient testing updates? [Yes or No]
    N/A
  • [x ] Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    N/A
  • [x ] Please complete this pull request review by [Fill in date].

    03-25-25

Pull Request Checklist

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Select: Reviewer(s)
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…tric tensor terms to accomodate terrain following coordinate frame.
… the formulation of cell face velocties (for advection terms) and calculation of pressure gradient force components.
…aing-following coordinate in sgsTKE prognostic equation and sgs Turbulence closure terms.
@jsauer-NCAR jsauer-NCAR requested a review from domingom March 25, 2025 18:34
@domingom
Copy link
Owner

Looks all good to me. Great job! :-)

@domingom domingom merged commit 1b0bd0d into develop Mar 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants