Bugfix to get the terrain following coordinate actually in place#10
Merged
Bugfix to get the terrain following coordinate actually in place#10
Conversation
…tric tensor terms to accomodate terrain following coordinate frame.
… the formulation of cell face velocties (for advection terms) and calculation of pressure gradient force components.
…in the moleuler diffusion term submodule.
…aing-following coordinate in sgsTKE prognostic equation and sgs Turbulence closure terms.
domingom
reviewed
Mar 25, 2025
domingom
reviewed
Mar 25, 2025
…ed Jacobian calculation routine
Owner
|
Looks all good to me. Great job! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected Differences
If yes, please describe:
No
Pull Request Testing
Verified flow sonsequences for a Ug=8.0 m/s flow past a 15m WOA hill in a periodic domain
No further testing at this time. Future CI test members should explicitly verify molecular diffusion and sgs turbulence, sgs TKE, etc.
No, a future pull request should patch the v2.0 release with adjustments to the terrain inclusive Dispersion tutorial examples.
N/A
If yes, describe the new output and/or changes to the existing output:
N/A
03-25-25
Pull Request Checklist