Skip to content

feature/TVCP#13

Merged
domingom merged 1 commit intodevelopfrom
feature/TVCP
Mar 31, 2025
Merged

feature/TVCP#13
domingom merged 1 commit intodevelopfrom
feature/TVCP

Conversation

@jsauer-NCAR
Copy link
Collaborator

@jsauer-NCAR jsauer-NCAR commented Mar 31, 2025

Implemented TVCP capability to go with hydroBCs==1 and existing CP submodule and added a few small code cleanup modifications.

Expected Differences

  • [ x] Do these changes introduce new tools, command line arguments, or configuration file options? [Yes or No]

    If yes, please describe:

    Time Varying Cell Perturbation

Pull Request Testing

  • [x ] Describe testing already performed for these changes:

    Working with coupling case established for testing PR feature/fe coupling Initial phase #11. Simply turned on cellpert_tvcp.
  • [x ] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    N/A
  • [x ] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    N/A
  • [ x] Do these changes include sufficient testing updates? [Yes or No]
    N/A
  • [ x] Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    N/A
  • [ x] Please complete this pull request review by [Fill in date].

    4/1/2005

Pull Request Checklist

  • [x ] Complete the PR definition above.
  • [x ] Ensure the PR title matches the feature or bugfix branch name.
  • [ x] Select: Reviewer(s)
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…bmodule and added a few small code cleanup modifications.
@jsauer-NCAR jsauer-NCAR requested a review from domingom March 31, 2025 21:52
@domingom domingom merged commit 62f7c01 into develop Mar 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants