Skip to content

feature/final_coupling_BCs_adjustments#15

Merged
domingom merged 1 commit intodevelopfrom
feature/final_coupling_BC_adjustments
Apr 1, 2025
Merged

feature/final_coupling_BCs_adjustments#15
domingom merged 1 commit intodevelopfrom
feature/final_coupling_BC_adjustments

Conversation

@jsauer-NCAR
Copy link
Collaborator

@jsauer-NCAR jsauer-NCAR commented Apr 1, 2025

Last additions to bring vertical ABL BCs under hydroBCs=1 in line with new formulation for u,v, and w that lack a base state description and to introduce the ceilingAdvectionBC parameter to accomodate coupling and turn off rigid-lid that sets w=0 at the ceiling.

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [Yes or No]

    If yes, please describe:

    New parameter ceilingAdvectionsBC

Pull Request Testing

  • Describe testing already performed for these changes:

    first 3 tutorial cases and the real case from PR feature/fe coupling Initial phase #11
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    None at this time
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    N/A
  • Do these changes include sufficient testing updates? [Yes or No]
    N/A
  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    N/A
  • Please complete this pull request review by [Fill in date].

    N/A

Pull Request Checklist

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Select: Reviewer(s)
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…h new formulation for u,v, and w that lack a base state description and to intrdoduce the ceilingAdvectionBC parameter to accomodate coupling and turn off rigid-lid that sets w=0 at the ceiling.
@jsauer-NCAR jsauer-NCAR requested a review from domingom April 1, 2025 23:21
@domingom
Copy link
Owner

domingom commented Apr 1, 2025

Looks good. Thank you!

@domingom domingom merged commit 37be1d9 into develop Apr 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants