Skip to content

Bugfix develop various#19

Merged
jprestop merged 4 commits intodevelopfrom
bugfix_develop_various
Feb 9, 2026
Merged

Bugfix develop various#19
jprestop merged 4 commits intodevelopfrom
bugfix_develop_various

Conversation

@jprestop
Copy link
Collaborator

@jprestop jprestop commented Jan 9, 2026

The changes here include:

  • Adding "if (surflayerSelector == 1)" around queryFloatParameter call for surflayer_wq with this commit.
  • Removing "atmosphere_boundary_layer_thickness" as a standard name for Inverse Obukhov length with this commit.
  • Correcting the units for qflux from "kg kg-1 m s-1" to "g kg-1 m s-1" with this commit.
  • Correcting the units for qskin from "kg kg-1" to "g kg-1" with this commit.

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Tested for a successful compilation on Casper. No other testing was done for these minor fixes.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the changes and suggested any necessary modifications

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
    None needed

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [At your convenience].

Pull Request Checklist

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Select: Reviewer(s)
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Collaborator

@jsauer-NCAR jsauer-NCAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Thank you

@jprestop jprestop merged commit 45cfa87 into develop Feb 9, 2026
1 check passed
@jprestop jprestop deleted the bugfix_develop_various branch February 9, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants