chore: replace glob with native node:fs globSync#1803
Closed
roli-lpci wants to merge 1 commit intodonmccurdy:mainfrom
Closed
chore: replace glob with native node:fs globSync#1803roli-lpci wants to merge 1 commit intodonmccurdy:mainfrom
roli-lpci wants to merge 1 commit intodonmccurdy:mainfrom
Conversation
Closes donmccurdy#1800 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
Thanks @roli-lpci! For the uses that were previously async — could you use |
Author
|
Good call — I'll update the async paths to use What's the project's minimum supported Node version? If it's >= 22, I'll switch to the native async glob. If < 22, I could use |
Owner
|
Hm, I'm getting the impression that this change is part of an experiment in generating many PRs, in bulk, with an LLM. I'd prefer that my projects not be included in these experiments. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
globpackage usage with nativenode:fsglobSyncinscripts/validate.cjsandpackages/core/test/io/node-io.test.tsrequire('fs')/require('path')torequire('node:fs')/require('node:path')in the validate scriptThe
globpackage was never listed as a direct dependency — it was accessed via hoisting from transitive dependencies. Nativefs.globSync(available since Node.js 22) provides the same functionality with zero external dependencies, and CI already tests on Node.js v22+.Closes #1800