Skip to content

Fix/403 err agent #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rubengmurray wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix/403 err agent #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bb980bf
fix 403 error ny adding new header
rubengmurray Jan 1, 2026
2118787
update test
rubengmurray Jan 1, 2026
7f9cbc7
fix agent test
rubengmurray Jan 1, 2026
e35e05e
DRY test user agent
rubengmurray Jan 1, 2026
640195e
DRY override
rubengmurray Jan 1, 2026
5202a78
rm unused imports
rubengmurray Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions source/request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ let API_URL = 'https://en.wikipedia.org/w/api.php?',
async function callAPI(url: string) {
const options: AxiosRequestConfig = {
headers: {
"User-Agent": USER_AGENT,
Copy link
Author

@rubengmurray rubengmurray Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #77 & #78

"Api-User-Agent": USER_AGENT,
},
};
Expand Down
1 change: 0 additions & 1 deletion test/pdf.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import * as request from '../source/request';
import wiki from "../source/index";
import { htmlString, notFoundJson } from './samples';
Copy link
Author

@rubengmurray rubengmurray Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused

import { pdfError } from '../source/errors';
import Page, { pdf } from '../source/page';
import { pageJson } from './samples';
Expand Down
9 changes: 7 additions & 2 deletions test/request.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,12 @@ import request, {makeRestRequest, setAPIUrl, returnRestUrl, setUserAgent} from '
import { wikiError } from '../source';
const fetchMock = jest.spyOn(axios, "get");

const expectedDefaultUserAgent = "wikipedia (https://github.com/dopecodez/Wikipedia/)";

const options: AxiosRequestConfig = {
headers: {
'Api-User-Agent': 'wikipedia (https://github.com/dopecodez/Wikipedia/)'
"User-Agent": expectedDefaultUserAgent,
'Api-User-Agent': expectedDefaultUserAgent
}
}
const baseConfig : AxiosResponse['config'] = { headers: new AxiosHeaders()};
Expand Down Expand Up @@ -86,11 +89,13 @@ test('Set language returns api url with language set', () => {

test('Set user agent and use it to call the api', async () => {
setUserAgent("testUser");
const userAgentOverride = "testUser";
fetchMock.mockImplementation(async () => { return response1 } );
await request({}, true);
const modifiedOptions : AxiosRequestConfig = {
headers: {
'Api-User-Agent': 'testUser'
"User-Agent": userAgentOverride,
'Api-User-Agent': userAgentOverride
}
}
expect(fetchMock).toHaveBeenCalledWith(
Expand Down
Loading