Win compatibility #47
Conversation
| var ttf2woff2 = require('ttf2woff2'); | ||
|
|
||
| module.exports = function(source, target) { | ||
| fs.writeFileSync(target, ttf2woff2(fs.readFileSync(source))); |
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 4 indent
| var fs = require('fs'); | ||
| var ttf2woff2 = require('ttf2woff2'); | ||
|
|
||
| module.exports = function(source, target) { |
There was a problem hiding this comment.
Missing function expression name func-names
Missing space before function parentheses space-before-function-paren
| module.exports = (source, target) => { | ||
| fs.writeFileSync(target, ttf2woff2(fs.readFileSync(source))); | ||
| var fs = require('fs'); | ||
| var ttf2woff2 = require('ttf2woff2'); |
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
Unable to resolve path to module 'ttf2woff2' import/no-unresolved
|
|
||
| module.exports = (source, target) => { | ||
| fs.writeFileSync(target, ttf2woff2(fs.readFileSync(source))); | ||
| var fs = require('fs'); |
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
| @@ -1,6 +1,8 @@ | |||
| const fs = require('fs'); | |||
| const ttf2woff2 = require('ttf2woff2'); | |||
| 'use strict'; | |||
There was a problem hiding this comment.
'use strict' is unnecessary inside of modules strict
| 'From command: ' + command + '\n' + | ||
| trim(result) + '\n' + | ||
| 'Your SVG file will probably not be in a working state'); | ||
|
|
There was a problem hiding this comment.
Trailing spaces not allowed no-trailing-spaces
| throw new FontFaceException( | ||
| 'ttf2svg command failed\n' + | ||
| 'From command: ' + command + '\n' + | ||
| trim(result) + '\n' + |
There was a problem hiding this comment.
'result' used outside of binding context block-scoped-var
|
|
||
| } catch (e) { | ||
| throw new FontFaceException( | ||
| 'ttf2svg command failed\n' + |
There was a problem hiding this comment.
Unexpected string concatenation prefer-template
|
|
||
|
|
||
| } catch (e) { | ||
| throw new FontFaceException( |
There was a problem hiding this comment.
Expected indentation of 6 spaces but found 8 indent
'FontFaceException' is not defined no-undef
| var result = execSync(command); | ||
|
|
||
|
|
||
| } catch (e) { |
There was a problem hiding this comment.
Block must not be padded by blank lines padded-blocks
2 participants
I’ve made some change in your fontfacegen package to work with Windows 10.