Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 23, 2026

Backport of #64337 to release/9.0. Removes baseline mechanism.

Description

The package baseline system tracked dependency versions across servicing releases but the code path was never executed in practice. This removes:

  • Baseline files: eng/Baseline.xml, eng/Baseline.Designer.props (1,115 lines)
  • Generator tool: eng/tools/BaselineGenerator/ (3 files, 432 lines)
  • Build logic: Baseline validation targets, reference resolution, and PropertyGroups from Directory.Build.targets, Packaging.targets, ResolveReferences.targets
  • Documentation: References in PreparingPatchUpdates.md, ReferenceResolution.md, UpdatingMajorVersionAndTFM.md
  • Scripts: Baseline generation step from CodeCheck.ps1
  • Solution entries: BaselineGenerator project from AspNetCore.sln and tools.slnf
  • Project suppressions: SuppressBaselineReference items from Microsoft.AspNetCore.Components.csproj

Differences from 10.0: Uses AspNetCore.sln (9.0) vs AspNetCore.slnx (10.0), version numbers reflect 9.0.13.

Note: Changes to auto-generated files (ProjectReferences.props, RequiresDelayedBuildProjects.props, SharedFramework.Local.props, ShippingAssemblies.props, TrimmableProjects.props) that were unrelated to the baseline removal have been reverted.

Customer Impact

None. Internal build system simplification only.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Removes dead code that was never executed. Build and test validation completed successfully.

Verification

  • Manual (required)
  • Automated

Built multiple projects successfully: Microsoft.AspNetCore.Components, Microsoft.AspNetCore.Http. Restore completed without errors.

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props
Original prompt

Backport the changes from PR #64337 ([release/10.0] Get rid of package baseline) in dotnet/aspnetcore to the release/9.0 branch.

Context:

Requirements:

  • Cherry-pick or reapply the commits from PR [release/10.0] Get rid of package baseline #64337 onto release/9.0, resolving any conflicts appropriately for the 9.0 codebase.
  • Ensure any version-specific paths, package names, or baseline configurations that differ in 9.0 are handled correctly.
  • Build and run tests to verify there are no regressions.
  • Update any documentation or configs if the package baseline removal affects them.
  • Prepare a PR targeting release/9.0 with a clear description including links to the original PR and a summary of changes.

PR description should include:

This pull request was created from Copilot chat.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@dotnet-policy-service
Copy link
Contributor

Hi @@copilot. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

Copilot AI and others added 2 commits January 23, 2026 18:27
Backport of PR #64337 from release/10.0 to release/9.0.
Removes the package baseline mechanism which is no longer needed.

Changes:
- Removed baseline file references from build configuration
- Deleted eng/Baseline.xml and eng/Baseline.Designer.props
- Deleted eng/tools/BaselineGenerator/ directory
- Removed baseline targets and references from build files
- Updated solution files to remove BaselineGenerator project
- Updated documentation to remove baseline references
- Removed ValidateBaseline property from Versions.props
- Removed SuppressBaselineReference from Components.csproj

Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback

Copilot AI changed the title [WIP] Backport changes from PR #64337 to release/9.0 [release/9.0] Remove package baseline Jan 23, 2026
Copilot AI requested a review from wtgodbe January 23, 2026 18:35
Reverted changes to 5 auto-generated files that were unrelated to the baseline removal:
- eng/ProjectReferences.props
- eng/RequiresDelayedBuildProjects.props
- eng/SharedFramework.Local.props
- eng/ShippingAssemblies.props
- eng/TrimmableProjects.props

These files were modified by the GenerateProjectList.ps1 script but the changes are not part of the baseline removal backport.

Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
@wtgodbe wtgodbe marked this pull request as ready for review January 23, 2026 22:34
@wtgodbe wtgodbe requested review from a team and dotnet-maestro-bot as code owners January 23, 2026 22:34
Copilot AI review requested due to automatic review settings January 23, 2026 22:34
@wtgodbe wtgodbe requested a review from captainsafia as a code owner January 23, 2026 22:34
@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Jan 23, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the package baseline mechanism from the ASP.NET Core 9.0 release branch, backporting changes from #64337 (release/10.0). The baseline system tracked dependency versions across servicing releases but was never executed in practice.

Changes:

  • Removes baseline files (Baseline.xml, Baseline.Designer.props totaling 1,115 lines)
  • Deletes the BaselineGenerator tool (3 files, 432 lines of code)
  • Removes build logic for baseline validation and reference resolution from MSBuild targets
  • Updates documentation to remove references to the baseline system
  • Removes baseline generation from CodeCheck.ps1 script
  • Removes project from solution files and cleans up project suppressions

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
eng/Baseline.xml Deleted 113-line baseline package list (9.0.10 versions)
eng/Baseline.Designer.props Deleted 1,002-line auto-generated baseline properties file
eng/tools/BaselineGenerator/README.md Deleted tool documentation
eng/tools/BaselineGenerator/Program.cs Deleted 398-line baseline generator implementation
eng/tools/BaselineGenerator/BaselineGenerator.csproj Deleted project file
eng/targets/ResolveReferences.targets Removed baseline reference resolution logic and validation
eng/targets/Packaging.targets Removed baseline version validation target
Directory.Build.targets Removed baseline import and version override logic
eng/Versions.props Removed ValidateBaseline property
AspNetCore.sln Removed BaselineGenerator project entries
eng/tools/tools.slnf Removed BaselineGenerator from solution filter
src/Components/Components/src/Microsoft.AspNetCore.Components.csproj Removed SuppressBaselineReference items
eng/scripts/CodeCheck.ps1 Removed baseline regeneration step
eng/Dependencies.props Removed baseline-related comments
docs/UpdatingMajorVersionAndTFM.md Removed baseline update instructions
docs/ReferenceResolution.md Removed baseline documentation sections
docs/PreparingPatchUpdates.md Removed baseline update instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants