-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[release/9.0] Remove package baseline #65208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/9.0
Are you sure you want to change the base?
Conversation
|
Hi @@copilot. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
Backport of PR #64337 from release/10.0 to release/9.0. Removes the package baseline mechanism which is no longer needed. Changes: - Removed baseline file references from build configuration - Deleted eng/Baseline.xml and eng/Baseline.Designer.props - Deleted eng/tools/BaselineGenerator/ directory - Removed baseline targets and references from build files - Updated solution files to remove BaselineGenerator project - Updated documentation to remove baseline references - Removed ValidateBaseline property from Versions.props - Removed SuppressBaselineReference from Components.csproj Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
wtgodbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback
Reverted changes to 5 auto-generated files that were unrelated to the baseline removal: - eng/ProjectReferences.props - eng/RequiresDelayedBuildProjects.props - eng/SharedFramework.Local.props - eng/ShippingAssemblies.props - eng/TrimmableProjects.props These files were modified by the GenerateProjectList.ps1 script but the changes are not part of the baseline removal backport. Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the package baseline mechanism from the ASP.NET Core 9.0 release branch, backporting changes from #64337 (release/10.0). The baseline system tracked dependency versions across servicing releases but was never executed in practice.
Changes:
- Removes baseline files (Baseline.xml, Baseline.Designer.props totaling 1,115 lines)
- Deletes the BaselineGenerator tool (3 files, 432 lines of code)
- Removes build logic for baseline validation and reference resolution from MSBuild targets
- Updates documentation to remove references to the baseline system
- Removes baseline generation from CodeCheck.ps1 script
- Removes project from solution files and cleans up project suppressions
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/Baseline.xml | Deleted 113-line baseline package list (9.0.10 versions) |
| eng/Baseline.Designer.props | Deleted 1,002-line auto-generated baseline properties file |
| eng/tools/BaselineGenerator/README.md | Deleted tool documentation |
| eng/tools/BaselineGenerator/Program.cs | Deleted 398-line baseline generator implementation |
| eng/tools/BaselineGenerator/BaselineGenerator.csproj | Deleted project file |
| eng/targets/ResolveReferences.targets | Removed baseline reference resolution logic and validation |
| eng/targets/Packaging.targets | Removed baseline version validation target |
| Directory.Build.targets | Removed baseline import and version override logic |
| eng/Versions.props | Removed ValidateBaseline property |
| AspNetCore.sln | Removed BaselineGenerator project entries |
| eng/tools/tools.slnf | Removed BaselineGenerator from solution filter |
| src/Components/Components/src/Microsoft.AspNetCore.Components.csproj | Removed SuppressBaselineReference items |
| eng/scripts/CodeCheck.ps1 | Removed baseline regeneration step |
| eng/Dependencies.props | Removed baseline-related comments |
| docs/UpdatingMajorVersionAndTFM.md | Removed baseline update instructions |
| docs/ReferenceResolution.md | Removed baseline documentation sections |
| docs/PreparingPatchUpdates.md | Removed baseline update instructions |
Backport of #64337 to release/9.0. Removes baseline mechanism.
Description
The package baseline system tracked dependency versions across servicing releases but the code path was never executed in practice. This removes:
eng/Baseline.xml,eng/Baseline.Designer.props(1,115 lines)eng/tools/BaselineGenerator/(3 files, 432 lines)Directory.Build.targets,Packaging.targets,ResolveReferences.targetsPreparingPatchUpdates.md,ReferenceResolution.md,UpdatingMajorVersionAndTFM.mdCodeCheck.ps1AspNetCore.slnandtools.slnfSuppressBaselineReferenceitems fromMicrosoft.AspNetCore.Components.csprojDifferences from 10.0: Uses
AspNetCore.sln(9.0) vsAspNetCore.slnx(10.0), version numbers reflect 9.0.13.Note: Changes to auto-generated files (
ProjectReferences.props,RequiresDelayedBuildProjects.props,SharedFramework.Local.props,ShippingAssemblies.props,TrimmableProjects.props) that were unrelated to the baseline removal have been reverted.Customer Impact
None. Internal build system simplification only.
Regression?
Risk
Removes dead code that was never executed. Build and test validation completed successfully.
Verification
Built multiple projects successfully:
Microsoft.AspNetCore.Components,Microsoft.AspNetCore.Http. Restore completed without errors.Packaging changes reviewed?
When servicing release/2.1
Original prompt
This pull request was created from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.