Add null validation httpsclientslim #65219
Open
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add null validation to HttpClientSlim Uri parameters
Add null validation for Uri parameters in public API methods
Description
This PR adds
ArgumentNullException.ThrowIfNull(requestUri)validation to public methods inHttpClientSlimthat acceptUriparameters but don't currently validate them.Methods updated:
GetStringAsync(Uri requestUri, bool validateCertificate)PostAsync(Uri requestUri, HttpContent content, bool validateCertificate)GetStream(Uri requestUri, bool validateCertificate)(private helper)GetSocket(Uri requestUri)Rationale to updating:
Without null validation, callers passing
nullwould receive aNullReferenceExceptiondeep in the method implementation. This change provides feedback withArgumentNullExceptioninstead which can improving diagnostics to make the API contract better explicit.Impact: