[release/8.0] Add support for hotfix branding #65252
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
changed the title
Contributor
|
Hi @@mmitche. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for "hotfix" as an additional pre-release label for ASP.NET Core 8.0 servicing builds, enabling the build system to recognize hotfix builds alongside regular servicing builds.
Changes:
- Modified the
IsServicingBuildcondition to accept both "servicing" and "hotfix" as valid pre-release labels
| <AspNetCoreMajorMinorVersion>$(AspNetCoreMajorVersion).$(AspNetCoreMinorVersion)</AspNetCoreMajorMinorVersion> | ||
| <!-- Servicing builds have different characteristics for the way dependencies, baselines, and versions are handled. --> | ||
| <IsServicingBuild Condition=" '$(PreReleaseVersionLabel)' == 'servicing' ">true</IsServicingBuild> | ||
| <IsServicingBuild Condition=" '$(PreReleaseVersionLabel)' == 'servicing' or '$(PreReleaseVersionLabel)' == 'hotfix'">true</IsServicingBuild> |
There was a problem hiding this comment.
Missing space before the closing quote and angle bracket. For consistency with other conditions in this file (see line 25), there should be a space before the closing ">.
Suggested change
| <IsServicingBuild Condition=" '$(PreReleaseVersionLabel)' == 'servicing' or '$(PreReleaseVersionLabel)' == 'hotfix'">true</IsServicingBuild> | |
| <IsServicingBuild Condition=" '$(PreReleaseVersionLabel)' == 'servicing' or '$(PreReleaseVersionLabel)' == 'hotfix' ">true</IsServicingBuild> |
mmitche
added
the
tell-mode
This was referenced Jan 28, 2026
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the pre-release label to be "hotfix" for 8.0