Skip to content

chore(deps): update tokio-reactor-trait requirement from 1.1.0 to 2.0.0#146

Open
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/cargo/tokio-reactor-trait-2.0.0
Open

chore(deps): update tokio-reactor-trait requirement from 1.1.0 to 2.0.0#146
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/cargo/tokio-reactor-trait-2.0.0

Conversation

@dependabot
Copy link

@dependabot dependabot bot commented on behalf of github Feb 3, 2025

Updates the requirements on tokio-reactor-trait to permit the latest version.

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@doubleailes doubleailes force-pushed the dependabot/cargo/tokio-reactor-trait-2.0.0 branch from d16086d to a38e945 Compare May 3, 2025 08:14
@qodo-code-review
Copy link

qodo-code-review bot commented May 3, 2025

CI Feedback 🧐

(Feedback updated until commit a38e945)

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: bench

Failed stage: ⏲️ Bench [❌]

Failure summary:

The build failed due to a Rust compilation error in the girolle project. The error occurred in the
file girolle/src/queue/mod.rs at line 21. The specific error is:

  • Error E0277: The trait bound tokio_reactor_trait::Tokio: reactor_trait::Reactor is not satisfied
  • This means that the Tokio struct from the tokio-reactor-trait crate doesn't implement the Reactor
    trait required by ConnectionProperties::with_reactor method
  • The error is likely caused by a version mismatch or incompatibility between the tokio-reactor-trait
    v2.0.0 and reactor-trait v2.0.0 packages

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    153:  env:
    154:  CARGO_TERM_COLOR: always
    155:  targets: 
    156:  components: 
    157:  ##[endgroup]
    158:  ##[group]Run : set $CARGO_HOME
    159:  �[36;1m: set $CARGO_HOME�[0m
    160:  �[36;1mecho CARGO_HOME=${CARGO_HOME:-"$HOME/.cargo"} >> $GITHUB_ENV�[0m
    161:  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
    162:  env:
    163:  CARGO_TERM_COLOR: always
    164:  ##[endgroup]
    165:  ##[group]Run : install rustup if needed
    166:  �[36;1m: install rustup if needed�[0m
    167:  �[36;1mif ! command -v rustup &>/dev/null; then�[0m
    168:  �[36;1m  curl --proto '=https' --tlsv1.2 --retry 10 --retry-connrefused --location --silent --show-error --fail https://sh.rustup.rs | sh -s -- --default-toolchain none -y�[0m
    169:  �[36;1m  echo "$CARGO_HOME/bin" >> $GITHUB_PATH�[0m
    ...
    
    229:  �[36;1mif [ -z "${CARGO_REGISTRIES_CRATES_IO_PROTOCOL+set}" -o -f "/home/runner/work/_temp"/.implicit_cargo_registries_crates_io_protocol ]; then�[0m
    230:  �[36;1m  if rustc +stable --version --verbose | grep -q '^release: 1\.6[89]\.'; then�[0m
    231:  �[36;1m    touch "/home/runner/work/_temp"/.implicit_cargo_registries_crates_io_protocol || true�[0m
    232:  �[36;1m    echo CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse >> $GITHUB_ENV�[0m
    233:  �[36;1m  elif rustc +stable --version --verbose | grep -q '^release: 1\.6[67]\.'; then�[0m
    234:  �[36;1m    touch "/home/runner/work/_temp"/.implicit_cargo_registries_crates_io_protocol || true�[0m
    235:  �[36;1m    echo CARGO_REGISTRIES_CRATES_IO_PROTOCOL=git >> $GITHUB_ENV�[0m
    236:  �[36;1m  fi�[0m
    237:  �[36;1mfi�[0m
    238:  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
    239:  env:
    240:  CARGO_TERM_COLOR: always
    241:  CARGO_HOME: /home/runner/.cargo
    242:  CARGO_INCREMENTAL: 0
    243:  ##[endgroup]
    244:  ##[group]Run : work around spurious network errors in curl 8.0
    245:  �[36;1m: work around spurious network errors in curl 8.0�[0m
    246:  �[36;1m# https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/timeout.20investigation�[0m
    ...
    
    280:  �[1m�[32m    Updating�[0m crates.io index
    281:  �[1m�[32m     Locking�[0m 298 packages to latest compatible versions
    282:  �[1m�[32m Downloading�[0m crates ...
    283:  �[1m�[32m  Downloaded�[0m amq-protocol-tcp v7.2.2
    284:  �[1m�[32m  Downloaded�[0m tokio-executor-trait v2.1.3
    285:  �[1m�[32m  Downloaded�[0m tinystr v0.7.6
    286:  �[1m�[32m  Downloaded�[0m reactor-trait v1.1.0
    287:  �[1m�[32m  Downloaded�[0m reactor-trait v2.0.0
    288:  �[1m�[32m  Downloaded�[0m powerfmt v0.2.0
    289:  �[1m�[32m  Downloaded�[0m rand_core v0.9.3
    290:  �[1m�[32m  Downloaded�[0m rusticata-macros v4.1.0
    291:  �[1m�[32m  Downloaded�[0m scopeguard v1.2.0
    292:  �[1m�[32m  Downloaded�[0m rustls-connector v0.20.2
    293:  �[1m�[32m  Downloaded�[0m zerocopy v0.8.25
    294:  �[1m�[32m  Downloaded�[0m thread_local v1.1.8
    295:  �[1m�[32m  Downloaded�[0m thiserror v2.0.12
    296:  �[1m�[32m  Downloaded�[0m sharded-slab v0.1.7
    ...
    
    315:  �[1m�[32m  Downloaded�[0m spin v0.9.8
    316:  �[1m�[32m  Downloaded�[0m socket2 v0.4.10
    317:  �[1m�[32m  Downloaded�[0m futures-macro v0.3.31
    318:  �[1m�[32m  Downloaded�[0m rustls v0.23.26
    319:  �[1m�[32m  Downloaded�[0m rustix v0.38.44
    320:  �[1m�[32m  Downloaded�[0m smallvec v1.15.0
    321:  �[1m�[32m  Downloaded�[0m shlex v1.3.0
    322:  �[1m�[32m  Downloaded�[0m sha2 v0.10.9
    323:  �[1m�[32m  Downloaded�[0m linux-raw-sys v0.4.15
    324:  �[1m�[32m  Downloaded�[0m sha1 v0.10.6
    325:  �[1m�[32m  Downloaded�[0m rustls-pemfile v2.2.0
    326:  �[1m�[32m  Downloaded�[0m rustls-native-certs v0.7.3
    327:  �[1m�[32m  Downloaded�[0m rustls-pki-types v1.11.0
    328:  �[1m�[32m  Downloaded�[0m aes v0.8.4
    329:  �[1m�[32m  Downloaded�[0m syn v2.0.101
    330:  �[1m�[32m  Downloaded�[0m thiserror-impl v2.0.12
    331:  �[1m�[32m  Downloaded�[0m stable_deref_trait v1.2.0
    ...
    
    557:  �[1m�[32m   Compiling�[0m slab v0.4.9
    558:  �[1m�[32m   Compiling�[0m lock_api v0.4.12
    559:  �[1m�[32m   Compiling�[0m base64ct v1.7.3
    560:  �[1m�[32m   Compiling�[0m icu_locid_transform_data v1.5.1
    561:  �[1m�[32m   Compiling�[0m serde v1.0.219
    562:  �[1m�[32m   Compiling�[0m litemap v0.7.5
    563:  �[1m�[32m   Compiling�[0m shlex v1.3.0
    564:  �[1m�[32m   Compiling�[0m writeable v0.5.5
    565:  �[1m�[32m   Compiling�[0m cc v1.2.21
    566:  �[1m�[32m   Compiling�[0m pem-rfc7468 v0.7.0
    567:  �[1m�[32m   Compiling�[0m tracing-core v0.1.33
    568:  �[1m�[32m   Compiling�[0m synstructure v0.13.2
    569:  �[1m�[32m   Compiling�[0m flagset v0.4.7
    570:  �[1m�[32m   Compiling�[0m zerocopy v0.8.25
    571:  �[1m�[32m   Compiling�[0m num-conv v0.1.0
    572:  �[1m�[32m   Compiling�[0m thiserror v2.0.12
    573:  �[1m�[32m   Compiling�[0m time-core v0.1.4
    ...
    
    576:  �[1m�[32m   Compiling�[0m const-oid v0.9.6
    577:  �[1m�[32m   Compiling�[0m scopeguard v1.2.0
    578:  �[1m�[32m   Compiling�[0m getrandom v0.3.2
    579:  �[1m�[32m   Compiling�[0m deranged v0.4.0
    580:  �[1m�[32m   Compiling�[0m time-macros v0.2.22
    581:  �[1m�[32m   Compiling�[0m displaydoc v0.2.5
    582:  �[1m�[32m   Compiling�[0m zerofrom-derive v0.1.6
    583:  �[1m�[32m   Compiling�[0m yoke-derive v0.7.5
    584:  �[1m�[32m   Compiling�[0m zerovec-derive v0.10.3
    585:  �[1m�[32m   Compiling�[0m serde_derive v1.0.219
    586:  �[1m�[32m   Compiling�[0m icu_provider_macros v1.5.0
    587:  �[1m�[32m   Compiling�[0m zerofrom v0.1.6
    588:  �[1m�[32m   Compiling�[0m yoke v0.7.5
    589:  �[1m�[32m   Compiling�[0m der_derive v0.7.3
    590:  �[1m�[32m   Compiling�[0m zerovec v0.10.4
    591:  �[1m�[32m   Compiling�[0m thiserror-impl v2.0.12
    592:  �[1m�[32m   Compiling�[0m der v0.7.10
    ...
    
    751:  �[1m�[32m   Compiling�[0m tokio-reactor-trait v2.0.0
    752:  �[1m�[32m   Compiling�[0m futures v0.3.31
    753:  �[1m�[32m   Compiling�[0m rayon v1.10.0
    754:  �[1m�[32m   Compiling�[0m clap v4.5.37
    755:  �[1m�[32m   Compiling�[0m ciborium v0.2.2
    756:  �[1m�[32m   Compiling�[0m plotters v0.3.7
    757:  �[1m�[32m   Compiling�[0m girolle_macro v1.8.5 (/home/runner/work/girolle/girolle/girolle_macro)
    758:  �[1m�[32m   Compiling�[0m tokio-executor-trait v2.1.3
    759:  �[1m�[32m   Compiling�[0m uuid v1.16.0
    760:  �[1m�[32m   Compiling�[0m tinytemplate v1.2.1
    761:  �[1m�[32m   Compiling�[0m is-terminal v0.4.16
    762:  �[1m�[32m   Compiling�[0m anes v0.1.6
    763:  �[1m�[32m   Compiling�[0m oorandom v11.1.5
    764:  �[1m�[32m   Compiling�[0m girolle v1.8.5 (/home/runner/work/girolle/girolle/girolle)
    765:  �[1m�[32m   Compiling�[0m criterion v0.5.1
    766:  �[0m�[1m�[38;5;9merror[E0277]�[0m�[0m�[1m: the trait bound `tokio_reactor_trait::Tokio: reactor_trait::Reactor` is not satisfied�[0m
    767:  �[0m  �[0m�[0m�[1m�[38;5;12m--> �[0m�[0mgirolle/src/queue/mod.rs:21:23�[0m
    ...
    
    794:  �[0m  �[0m�[0m�[1m�[38;5;12m::: �[0m�[0m/home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-reactor-trait-2.0.0/src/lib.rs:15:1�[0m
    795:  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
    796:  �[0m�[1m�[38;5;12m15�[0m�[0m �[0m�[0m�[1m�[38;5;12m|�[0m�[0m �[0m�[0mpub struct Tokio;�[0m
    797:  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m�[0m �[0m�[0m�[1m�[38;5;12m----------------�[0m�[0m �[0m�[0m�[1m�[38;5;12mthis type doesn't implement the required trait�[0m
    798:  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
    799:  �[0m  �[0m�[0m�[1m�[38;5;12m::: �[0m�[0m/home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/reactor-trait-2.0.0/src/lib.rs:82:1�[0m
    800:  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
    801:  �[0m�[1m�[38;5;12m82�[0m�[0m �[0m�[0m�[1m�[38;5;12m|�[0m�[0m �[0m�[0mpub trait AsyncIOHandle: AsyncRead + AsyncWrite {}�[0m
    802:  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m�[0m �[0m�[0m�[1m�[38;5;12m-----------------------------------------------�[0m�[0m �[0m�[0m�[1m�[38;5;12mthis is the found trait�[0m
    803:  �[0m   �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mhelp�[0m�[0m: you can use `�[0m�[0m�[1m�[35mcargo tree�[0m�[0m` to explore your dependency tree�[0m
    804:  �[0m�[1m�[38;5;10mnote�[0m�[0m: required by a bound in `ConnectionProperties::with_reactor`�[0m
    805:  �[0m  �[0m�[0m�[1m�[38;5;12m--> �[0m�[0m/home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/lapin-2.5.3/src/connection_properties.rs:42:28�[0m
    806:  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
    807:  �[0m�[1m�[38;5;12m42�[0m�[0m �[0m�[0m�[1m�[38;5;12m|�[0m�[0m �[0m�[0m    pub fn with_reactor<R: Reactor + Send + Sync + 'static>(mut self, reactor: R) -> Self {�[0m
    808:  �[0m   �[0m�[0m�[1m�[38;5;12m|�[0m�[0m                            �[0m�[0m�[1m�[38;5;10m^^^^^^^�[0m�[0m �[0m�[0m�[1m�[38;5;10mrequired by this bound in `ConnectionProperties::with_reactor`�[0m
    809:  �[0m�[1mFor more information about this error, try `rustc --explain E0277`.�[0m
    810:  �[1m�[31merror�[0m�[1m:�[0m could not compile `girolle` (lib) due to 1 previous error
    811:  �[1m�[33mwarning�[0m�[1m:�[0m build failed, waiting for other jobs to finish...
    812:  ##[error]Process completed with exit code 101.
    813:  Post job cleanup.
    

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant