Skip to content

Conversation

@bsneed
Copy link
Contributor

@bsneed bsneed commented Apr 1, 2024

@dcvz
Copy link
Collaborator

dcvz commented Apr 11, 2024

@bsneed your PR #73 there's also been some changes to add CI workflow for macOS. Would you mind rebasing? since your PR was squashed commit the easiest way will be to just apply the commits that changed:

git rebase --onto main HEAD~X where X is the number of commits different than the base branch that got merged.

@bsneed
Copy link
Contributor Author

bsneed commented Apr 11, 2024

Heya @dcvz, thanks! Just updated and will keep an eye on the CI here.

@codecov
Copy link

codecov bot commented Apr 11, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@dcvz
Copy link
Collaborator

dcvz commented Apr 12, 2024

@bsneed I'll try to review this today or over the weekend. I've updated the example app you started to be universal for both platforms. It would be really cool to have a usage of the taps on it (a simple waveform?) in case you're interested. It's not mandatory for merge though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose current buffer for visualisation/waveform rendering

2 participants