Refactor maps to allow custom pins and animated scaling#1483
Draft
dylankelly wants to merge 3 commits intodevelopfrom
Draft
Refactor maps to allow custom pins and animated scaling#1483dylankelly wants to merge 3 commits intodevelopfrom
dylankelly wants to merge 3 commits intodevelopfrom
Conversation
✅ Deploy Preview for ripple-docs canceled.
|
ripple-framework
|
||||||||||||||||||||||||||||||||||
| Project |
ripple-framework
|
| Branch Review |
feature/refactor-maps
|
| Run status |
|
| Run duration | 13m 58s |
| Commit |
|
| Committer | Dylan Kelly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
4
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
245
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
maps.feature • 3 failed tests
vsba.feature • 1 failed test
| Test | Artifacts | |
|---|---|---|
| School buildings map > Click on cluster should zoom in |
Test Replay
Screenshots
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
How to test
Checklist
For all PR's
For new UI components only
emitRplEvent