Merged
Conversation
Contributor
Author
|
i'm a genius and committed to main 😭 |
EstebenR
reviewed
Feb 4, 2025
dphfox
reviewed
Feb 7, 2025
dphfox
requested changes
Feb 10, 2025
Owner
dphfox
left a comment
dphfox
left a comment
There was a problem hiding this comment.
This should also be unit tested - sorry for the delay in review.
Contributor
Author
|
Isn't unit tests blocked by #421? I don't think it'll make sense writing tests in TestEZ when in the near future, it'll be rewritten completely. |
Owner
|
It's still wise to unit test new features in the interim because it gives me something to transcribe into the new testing framework. |
Contributor
|
I've submitted a PR on the head repo to add tests. |
dphfox
approved these changes
Dec 8, 2025
Owner
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #36