Add a shallow comparison check to make comparing two tables easier.#1
Open
Raild3x wants to merge 4 commits intodphfox:mainfrom
Open
Add a shallow comparison check to make comparing two tables easier.#1Raild3x wants to merge 4 commits intodphfox:mainfrom
Raild3x wants to merge 4 commits intodphfox:mainfrom
Conversation
Currently comparing two tables for shallow equivalency can be a pain and causes syntax not inline with other tests. I propose an additional expect test for being able to compare two tables.
```lua
describe("Append", function()
test("should append values and maintain order", function()
local queue = Queue.new()
queue:Append(11)
queue:Append(12)
queue:Append(13)
expect(queue:ToArray()).is_shallow_equal({11, 12, 13})
end)
end)
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently comparing two tables for shallow equivalency can be a pain and causes syntax not inline with other tests. I propose an additional expect test for being able to compare two tables.
Also included is a deep equal comparison check.