Skip to content

Conversation

Copy link

Copilot AI commented Dec 9, 2025

Addresses inconsistent validation behavior where validIntWithRange clamped values exceeding limits instead of rejecting them, despite tests expecting rejection.

Changes

  • ParamValidator.scala line 502: Changed from returning max to throwing ValidationException when int > max

This ensures parameters like page_size=999999 are rejected (as tests expect) rather than silently clamped to the configured maximum.

// Before
else if (int > max) max

// After  
else if (int > max) throw ValidationException(rule)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@coderabbitai
Copy link

coderabbitai bot commented Dec 9, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI and others added 2 commits December 9, 2025 15:13
Co-authored-by: moltude <1419766+moltude@users.noreply.github.com>
Co-authored-by: moltude <1419766+moltude@users.noreply.github.com>
Copy link
Author

Copilot AI commented Dec 9, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)
  • get.sdkman.io
    • Triggering command: /usr/bin/curl curl -s REDACTED (dns block)
  • repo.scala-sbt.org
    • Triggering command: /usr/bin/java java -jar /home/REDACTED/work/api/api/sbt/bin/sbt-launch.jar sbtVersion (dns block)
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https --keyring /etc/apt/trusted.gpg.d/ubuntu-keyring-2012-cdimage.gpg --batch --import --import-options merge-only (dns block)
  • repo.typesafe.com
    • Triggering command: /usr/bin/java java -jar /home/REDACTED/work/api/api/sbt/bin/sbt-launch.jar sbtVersion (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] WIP address feedback on API improvements in Phase 2 PR Fix parameter validation to reject over-limit values instead of clamping Dec 9, 2025
Copilot AI requested a review from moltude December 9, 2025 15:17
@moltude moltude closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants