Skip to content

Fix controller_rest's issue with page paths #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loetie merged 1 commit into from
Feb 9, 2026
Merged

Fix controller_rest's issue with page paths #756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions modules/mod_ginger_base/controllers/controller_rest_resources.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,15 @@ path_to_id("/", Context) ->
path_to_id(Path, Context) ->
case string:tokens(Path, "/") of
["page", Id | _] ->
{ok, erlang:list_to_integer(Id)};
case m_rsc:rid(Id, Context) of
undefined -> {error, enoent};
Copy link
Contributor

@loetie loetie Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pasqu4le should this be treated as a page path then if it is not page/id? so it still checks m_rsc:page_path_to_id, like in the else of the case above this one?

Copy link
Contributor Author

@pasqu4le pasqu4le Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be treated as a page path then if it is not page/id?

Good question, but I don't think so. If the path starts with "page" then it's handled by the page dispatch/controller and it should have an identifier (id or otherwise).

If it's not, I don't think we should treat it as another path.

RscId -> {ok, RscId}
end;
[_Language, "page", Id | _] ->
{ok, erlang:list_to_integer(Id)};
case m_rsc:rid(Id, Context) of
undefined -> {error, enoent};
RscId -> {ok, RscId}
end;
_ ->
case m_rsc:page_path_to_id(Path, Context) of
{redirect, Id} ->
Expand Down