Skip to content

Conversation

@jtourkos
Copy link
Collaborator

@jtourkos jtourkos commented Oct 1, 2025

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds "deadline" support across the SDK, including new driver resolution, conversion utilities, and behaviors around donation and Drip List creation/update. The PR also introduces comprehensive unit/integration tests for deadline-related flows and removes the testing-app sandbox.

  • Add tests for deadline timestamp conversion and repoDeadline driver resolution
  • Extend Drip List creation/update logic and tests with allowExternalDonations and deadline-config parsing
  • Add unit/integration tests for calculating deadline driver account IDs and one-time donations with deadlines, and remove testing-app

Reviewed Changes

Copilot reviewed 142 out of 198 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tests/unit/shared/toDeadlineSeconds.test.ts New tests for validating Date-to-seconds conversion and error cases.
tests/unit/shared/resolveDriverName.test.ts Adds support for driver ID 5 as repoDeadline; updates unknown ID tests.
tests/unit/shared/receiverUtils.test.ts Tests for resolving deadline accounts and parsing receivers with deadline config.
tests/unit/shared/calcDeadlineDriverAccountId.test.ts Extensive tests around building calls, chain-specific contracts, and edge cases.
tests/unit/dripLists/updateDripList.test.ts Updates expected return shape to include allowExternalDonations.
tests/unit/dripLists/prepareDripListUpdate.test.ts Tests allowExternalDonations toggling logic based on deadline receivers.
tests/unit/dripLists/prepareDripListCreation.test.ts Adds owner account resolution and allowExternalDonations metadata; deadlines parsing.
tests/unit/dripLists/createDripList.test.ts Aligns expectations to include allowExternalDonations; minor text change.
tests/unit/dripLists/buildDripListMetadata.test.ts Ensures allowExternalDonations is part of built metadata.
tests/unit/donations/prepareOneTimeDonation.test.ts Adds deadline-config flows for project receivers, with validation error tests.
tests/integration/deadlines.integration.test.ts Integration tests for creating Drip Lists with deadlines and verifying splits hash.
testing-app/* Removes testing app configs and routes (no behavior impact on SDK).
Files not reviewed (1)
  • testing-app/package-lock.json: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants